Skip to content

Commit 692a497

Browse files
committed
USB: serial: ti_usb_3410_5052: drop bogus read urb check
The read urb pointer is dereferenced before checking that it is non-NULL during open(), but no check is needed as the existence of a bulk in endpoint is verified during attach() since commit ef07993 ("USB: serial: ti_usb_3410_5052: fix NULL-deref at open"). Drop the bogus read urb sanity check. Signed-off-by: Johan Hovold <[email protected]>
1 parent b443265 commit 692a497

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/usb/serial/ti_usb_3410_5052.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -729,11 +729,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port)
729729

730730
/* start read urb */
731731
urb = port->read_urb;
732-
if (!urb) {
733-
dev_err(&port->dev, "%s - no read urb\n", __func__);
734-
status = -EINVAL;
735-
goto unlink_int_urb;
736-
}
737732
tport->tp_read_urb_state = TI_READ_URB_RUNNING;
738733
urb->context = tport;
739734
status = usb_submit_urb(urb, GFP_KERNEL);

0 commit comments

Comments
 (0)