Skip to content

Commit 6982e6b

Browse files
author
Bartosz Golaszewski
committed
ARM: orion/gpio: use new line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Andrew Lunn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent 0af2f6b commit 6982e6b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

arch/arm/plat-orion/gpio.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,14 +211,16 @@ orion_gpio_direction_output(struct gpio_chip *chip, unsigned pin, int value)
211211
return 0;
212212
}
213213

214-
static void orion_gpio_set(struct gpio_chip *chip, unsigned pin, int value)
214+
static int orion_gpio_set(struct gpio_chip *chip, unsigned int pin, int value)
215215
{
216216
struct orion_gpio_chip *ochip = gpiochip_get_data(chip);
217217
unsigned long flags;
218218

219219
spin_lock_irqsave(&ochip->lock, flags);
220220
__set_level(ochip, pin, value);
221221
spin_unlock_irqrestore(&ochip->lock, flags);
222+
223+
return 0;
222224
}
223225

224226
static int orion_gpio_to_irq(struct gpio_chip *chip, unsigned pin)
@@ -540,7 +542,7 @@ void __init orion_gpio_init(int gpio_base, int ngpio,
540542
ochip->chip.direction_input = orion_gpio_direction_input;
541543
ochip->chip.get = orion_gpio_get;
542544
ochip->chip.direction_output = orion_gpio_direction_output;
543-
ochip->chip.set = orion_gpio_set;
545+
ochip->chip.set_rv = orion_gpio_set;
544546
ochip->chip.to_irq = orion_gpio_to_irq;
545547
ochip->chip.base = gpio_base;
546548
ochip->chip.ngpio = ngpio;

0 commit comments

Comments
 (0)