Skip to content

Commit 69f4ec1

Browse files
Xiang Chenmartinkpetersen
authored andcommitted
scsi: hisi_sas: Recover PHY state according to the status before reset
Currently the PHY state is set according to the state of the PHYs after reset. This is invalid as the PHYs are already re-initialized. Set PHY state according to the state before the reset instead of after. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Xiang Chen <[email protected]> Signed-off-by: John Garry <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent b14a37e commit 69f4ec1

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/scsi/hisi_sas/hisi_sas_main.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1551,7 +1551,6 @@ EXPORT_SYMBOL_GPL(hisi_sas_controller_reset_prepare);
15511551
void hisi_sas_controller_reset_done(struct hisi_hba *hisi_hba)
15521552
{
15531553
struct Scsi_Host *shost = hisi_hba->shost;
1554-
u32 state;
15551554

15561555
/* Init and wait for PHYs to come up and all libsas event finished. */
15571556
hisi_hba->hw->phys_init(hisi_hba);
@@ -1566,8 +1565,7 @@ void hisi_sas_controller_reset_done(struct hisi_hba *hisi_hba)
15661565
scsi_unblock_requests(shost);
15671566
clear_bit(HISI_SAS_RESET_BIT, &hisi_hba->flags);
15681567

1569-
state = hisi_hba->hw->get_phys_state(hisi_hba);
1570-
hisi_sas_rescan_topology(hisi_hba, state);
1568+
hisi_sas_rescan_topology(hisi_hba, hisi_hba->phy_state);
15711569
}
15721570
EXPORT_SYMBOL_GPL(hisi_sas_controller_reset_done);
15731571

0 commit comments

Comments
 (0)