Skip to content

Commit 69ff53e

Browse files
hkallweitkuba-moo
authored andcommitted
net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY
Jerome provided the information that also the GXL internal PHY doesn't support MMD register access and EEE. MMD reads return 0xffff, what results in e.g. completely wrong ethtool --show-eee output. Therefore use the MMD dummy stubs. Fixes: d853d14 ("net: phy: add an option to disable EEE advertisement") Suggested-by: Jerome Brunet <[email protected]> Signed-off-by: Heiner Kallweit <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c9011b0 commit 69ff53e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/phy/meson-gxl.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,8 @@ static struct phy_driver meson_gxl_phy[] = {
261261
.handle_interrupt = meson_gxl_handle_interrupt,
262262
.suspend = genphy_suspend,
263263
.resume = genphy_resume,
264+
.read_mmd = genphy_read_mmd_unsupported,
265+
.write_mmd = genphy_write_mmd_unsupported,
264266
}, {
265267
PHY_ID_MATCH_EXACT(0x01803301),
266268
.name = "Meson G12A Internal PHY",

0 commit comments

Comments
 (0)