Skip to content

Commit 6a3ecfd

Browse files
drm/i915/guc: Suppress 'ignoring reset notification' message
If an active context has been banned (e.g. Ctrl+C killed) then it is likely to be reset as part of evicting it from the hardware. That results in a 'ignoring context reset notification: banned = 1' message at info level. This confuses/concerns people and makes them think something has gone wrong when it hasn't. There is already a debug level message with essentially the same information. So drop the 'ignore' info level one and just add the 'ignore' flag to the debug level one instead (which will therefore not appear by default but will still show up in CI runs). Signed-off-by: John Harrison <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 6b8ace7 commit 6a3ecfd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4802,19 +4802,19 @@ static void guc_context_replay(struct intel_context *ce)
48024802
static void guc_handle_context_reset(struct intel_guc *guc,
48034803
struct intel_context *ce)
48044804
{
4805+
bool capture = intel_context_is_schedulable(ce);
4806+
48054807
trace_intel_context_reset(ce);
48064808

4807-
guc_dbg(guc, "Got context reset notification: 0x%04X on %s, exiting = %s, banned = %s\n",
4809+
guc_dbg(guc, "%s context reset notification: 0x%04X on %s, exiting = %s, banned = %s\n",
4810+
capture ? "Got" : "Ignoring",
48084811
ce->guc_id.id, ce->engine->name,
48094812
str_yes_no(intel_context_is_exiting(ce)),
48104813
str_yes_no(intel_context_is_banned(ce)));
48114814

4812-
if (likely(intel_context_is_schedulable(ce))) {
4815+
if (capture) {
48134816
capture_error_state(guc, ce);
48144817
guc_context_replay(ce);
4815-
} else {
4816-
guc_info(guc, "Ignoring context reset notification of exiting context 0x%04X on %s",
4817-
ce->guc_id.id, ce->engine->name);
48184818
}
48194819
}
48204820

0 commit comments

Comments
 (0)