Skip to content

Commit 6a5ef3b

Browse files
lkundraklynxeye-dev
authored andcommitted
drm/etnaviv: Simplify clock enable/disable
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel <[email protected]> Signed-off-by: Lucas Stach <[email protected]>
1 parent a59052d commit 6a5ef3b

File tree

1 file changed

+19
-34
lines changed

1 file changed

+19
-34
lines changed

drivers/gpu/drm/etnaviv/etnaviv_gpu.c

Lines changed: 19 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1487,55 +1487,40 @@ static int etnaviv_gpu_clk_enable(struct etnaviv_gpu *gpu)
14871487
{
14881488
int ret;
14891489

1490-
if (gpu->clk_reg) {
1491-
ret = clk_prepare_enable(gpu->clk_reg);
1492-
if (ret)
1493-
return ret;
1494-
}
1490+
ret = clk_prepare_enable(gpu->clk_reg);
1491+
if (ret)
1492+
return ret;
14951493

1496-
if (gpu->clk_bus) {
1497-
ret = clk_prepare_enable(gpu->clk_bus);
1498-
if (ret)
1499-
goto disable_clk_reg;
1500-
}
1494+
ret = clk_prepare_enable(gpu->clk_bus);
1495+
if (ret)
1496+
goto disable_clk_reg;
15011497

1502-
if (gpu->clk_core) {
1503-
ret = clk_prepare_enable(gpu->clk_core);
1504-
if (ret)
1505-
goto disable_clk_bus;
1506-
}
1498+
ret = clk_prepare_enable(gpu->clk_core);
1499+
if (ret)
1500+
goto disable_clk_bus;
15071501

1508-
if (gpu->clk_shader) {
1509-
ret = clk_prepare_enable(gpu->clk_shader);
1510-
if (ret)
1511-
goto disable_clk_core;
1512-
}
1502+
ret = clk_prepare_enable(gpu->clk_shader);
1503+
if (ret)
1504+
goto disable_clk_core;
15131505

15141506
return 0;
15151507

15161508
disable_clk_core:
1517-
if (gpu->clk_core)
1518-
clk_disable_unprepare(gpu->clk_core);
1509+
clk_disable_unprepare(gpu->clk_core);
15191510
disable_clk_bus:
1520-
if (gpu->clk_bus)
1521-
clk_disable_unprepare(gpu->clk_bus);
1511+
clk_disable_unprepare(gpu->clk_bus);
15221512
disable_clk_reg:
1523-
if (gpu->clk_reg)
1524-
clk_disable_unprepare(gpu->clk_reg);
1513+
clk_disable_unprepare(gpu->clk_reg);
15251514

15261515
return ret;
15271516
}
15281517

15291518
static int etnaviv_gpu_clk_disable(struct etnaviv_gpu *gpu)
15301519
{
1531-
if (gpu->clk_shader)
1532-
clk_disable_unprepare(gpu->clk_shader);
1533-
if (gpu->clk_core)
1534-
clk_disable_unprepare(gpu->clk_core);
1535-
if (gpu->clk_bus)
1536-
clk_disable_unprepare(gpu->clk_bus);
1537-
if (gpu->clk_reg)
1538-
clk_disable_unprepare(gpu->clk_reg);
1520+
clk_disable_unprepare(gpu->clk_shader);
1521+
clk_disable_unprepare(gpu->clk_core);
1522+
clk_disable_unprepare(gpu->clk_bus);
1523+
clk_disable_unprepare(gpu->clk_reg);
15391524

15401525
return 0;
15411526
}

0 commit comments

Comments
 (0)