Skip to content

Commit 6a878a5

Browse files
Sricharan Ramabadhranbjorn-helgaas
authored andcommitted
PCI: qcom: Fix IPQ8074 enumeration
PARF_SLV_ADDR_SPACE_SIZE_2_3_3 is used by qcom_pcie_post_init_2_3_3(). This PCIe slave address space size register offset is 0x358 but was incorrectly changed to 0x16c by 39171b3 ("PCI: qcom: Remove PCIE20_ prefix from register definitions"). This prevented access to slave address space registers like iATU, etc., so the IPQ8074 PCIe controller was not enumerated. Revert back to the correct 0x358 offset and remove the unused PARF_SLV_ADDR_SPACE_SIZE_2_3_3. Fixes: 39171b3 ("PCI: qcom: Remove PCIE20_ prefix from register definitions") Link: https://lore.kernel.org/r/[email protected] Tested-by: Robert Marko <[email protected]> Signed-off-by: Sricharan Ramabadhran <[email protected]> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Cc: [email protected] # v6.4+
1 parent 0bb80ec commit 6a878a5

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/dwc/pcie-qcom.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
#define PARF_PHY_REFCLK 0x4c
4444
#define PARF_CONFIG_BITS 0x50
4545
#define PARF_DBI_BASE_ADDR 0x168
46-
#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16c /* Register offset specific to IP ver 2.3.3 */
4746
#define PARF_MHI_CLOCK_RESET_CTRL 0x174
4847
#define PARF_AXI_MSTR_WR_ADDR_HALT 0x178
4948
#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1a8
@@ -797,8 +796,7 @@ static int qcom_pcie_post_init_2_3_3(struct qcom_pcie *pcie)
797796
u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
798797
u32 val;
799798

800-
writel(SLV_ADDR_SPACE_SZ,
801-
pcie->parf + PARF_SLV_ADDR_SPACE_SIZE_2_3_3);
799+
writel(SLV_ADDR_SPACE_SZ, pcie->parf + PARF_SLV_ADDR_SPACE_SIZE);
802800

803801
val = readl(pcie->parf + PARF_PHY_CTRL);
804802
val &= ~PHY_TEST_PWR_DOWN;

0 commit comments

Comments
 (0)