Skip to content

Commit 6ab39f9

Browse files
ardbiesheuvelherbertx
authored andcommitted
crypto: x86/aria - Use 16 byte alignment for GFNI constant vectors
The GFNI routines in the AVX version of the ARIA implementation now use explicit VMOVDQA instructions to load the constant input vectors, which means they must be 16 byte aligned. So ensure that this is the case, by dropping the section split and the incorrect .align 8 directive, and emitting the constants into the 16-byte aligned section instead. Note that the AVX2 version of this code deviates from this pattern, and does not require a similar fix, given that it loads these contants as 8-byte memory operands, for which AVX2 permits any alignment. Cc: Taehee Yoo <[email protected]> Fixes: 8b84475 ("crypto: x86/aria-avx - Do not use avx2 instructions") Reported-by: [email protected] Tested-by: [email protected] Signed-off-by: Ard Biesheuvel <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent b8969a1 commit 6ab39f9

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

arch/x86/crypto/aria-aesni-avx-asm_64.S

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -773,8 +773,6 @@
773773
.octa 0x3F893781E95FE1576CDA64D2BA0CB204
774774

775775
#ifdef CONFIG_AS_GFNI
776-
.section .rodata.cst8, "aM", @progbits, 8
777-
.align 8
778776
/* AES affine: */
779777
#define tf_aff_const BV8(1, 1, 0, 0, 0, 1, 1, 0)
780778
.Ltf_aff_bitmatrix:

0 commit comments

Comments
 (0)