Skip to content

Commit 6b3b21a

Browse files
elfringwsakernel
authored andcommitted
i2c: Delete error messages for failed memory allocations
These issues were detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 1ebafd5 commit 6b3b21a

File tree

4 files changed

+2
-8
lines changed

4 files changed

+2
-8
lines changed

drivers/i2c/busses/i2c-ibm_iic.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -694,10 +694,8 @@ static int iic_probe(struct platform_device *ofdev)
694694
int ret;
695695

696696
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
697-
if (!dev) {
698-
dev_err(&ofdev->dev, "failed to allocate device data\n");
697+
if (!dev)
699698
return -ENOMEM;
700-
}
701699

702700
platform_set_drvdata(ofdev, dev);
703701

drivers/i2c/busses/i2c-nomadik.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -972,7 +972,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
972972

973973
dev = devm_kzalloc(&adev->dev, sizeof(struct nmk_i2c_dev), GFP_KERNEL);
974974
if (!dev) {
975-
dev_err(&adev->dev, "cannot allocate memory\n");
976975
ret = -ENOMEM;
977976
goto err_no_mem;
978977
}

drivers/i2c/busses/i2c-sh7760.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,6 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
445445

446446
id = kzalloc(sizeof(struct cami2c), GFP_KERNEL);
447447
if (!id) {
448-
dev_err(&pdev->dev, "no mem for private data\n");
449448
ret = -ENOMEM;
450449
goto out0;
451450
}

drivers/i2c/busses/i2c-tiny-usb.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface,
226226

227227
/* allocate memory for our device state and initialize it */
228228
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
229-
if (dev == NULL) {
230-
dev_err(&interface->dev, "Out of memory\n");
229+
if (!dev)
231230
goto error;
232-
}
233231

234232
dev->usb_dev = usb_get_dev(interface_to_usbdev(interface));
235233
dev->interface = interface;

0 commit comments

Comments
 (0)