Skip to content

Commit 6b8d1e4

Browse files
Lee Jonesbroonie
authored andcommitted
spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data'
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'quirks' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'clk_ioclk' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'pdev' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'rx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'tx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_conf' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_id' not described in 's3c64xx_spi_driver_data' Signed-off-by: Lee Jones <[email protected]> Cc: Kukjin Kim <[email protected]> Cc: Krzysztof Kozlowski <[email protected]> Cc: Andi Shyti <[email protected]> Cc: Jaswinder Singh <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent d9b883a commit 6b8d1e4

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

drivers/spi/spi-s3c64xx.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,11 @@ struct s3c64xx_spi_dma_data {
130130
* @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register.
131131
* @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter.
132132
* @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter.
133+
* @quirks: Bitmask of known quirks
133134
* @high_speed: True, if the controller supports HIGH_SPEED_EN bit.
134135
* @clk_from_cmu: True, if the controller does not include a clock mux and
135136
* prescaler unit.
137+
* @clk_ioclk: True if clock is present on this device
136138
*
137139
* The Samsung s3c64xx SPI controller are used on various Samsung SoC's but
138140
* differ in some aspects such as the size of the fifo and spi bus clock
@@ -154,6 +156,7 @@ struct s3c64xx_spi_port_config {
154156
* @clk: Pointer to the spi clock.
155157
* @src_clk: Pointer to the clock used to generate SPI signals.
156158
* @ioclk: Pointer to the i/o clock between master and slave
159+
* @pdev: Pointer to device's platform device data
157160
* @master: Pointer to the SPI Protocol master.
158161
* @cntrlr_info: Platform specific data for the controller this driver manages.
159162
* @lock: Controller specific lock.
@@ -166,7 +169,11 @@ struct s3c64xx_spi_port_config {
166169
* @xfer_completion: To indicate completion of xfer task.
167170
* @cur_mode: Stores the active configuration of the controller.
168171
* @cur_bpw: Stores the active bits per word settings.
169-
* @cur_speed: Stores the active xfer clock speed.
172+
* @cur_speed: Current clock speed
173+
* @rx_dma: Local receive DMA data (e.g. chan and direction)
174+
* @tx_dma: Local transmit DMA data (e.g. chan and direction)
175+
* @port_conf: Local SPI port configuartion data
176+
* @port_id: Port identification number
170177
*/
171178
struct s3c64xx_spi_driver_data {
172179
void __iomem *regs;

0 commit comments

Comments
 (0)