Skip to content

Commit 6b9875a

Browse files
committed
s390/ctcm: use new address translation helpers
Use virt_to_dma32() and friends to properly convert virtual to physical and physical to virtual addresses so that "make C=1" does not generate any warnings anymore. Signed-off-by: Heiko Carstens <[email protected]>
1 parent 9608142 commit 6b9875a

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

drivers/s390/net/ctcm_fsms.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,7 +1325,7 @@ static void ctcmpc_chx_txdone(fsm_instance *fi, int event, void *arg)
13251325
clear_normalized_cda(&ch->ccw[1]);
13261326

13271327
CTCM_PR_DBGDATA("ccwcda=0x%p data=0x%p\n",
1328-
(void *)(unsigned long)ch->ccw[1].cda,
1328+
(void *)(u64)dma32_to_u32(ch->ccw[1].cda),
13291329
ch->trans_skb->data);
13301330
ch->ccw[1].count = ch->max_bufsize;
13311331

@@ -1340,7 +1340,7 @@ static void ctcmpc_chx_txdone(fsm_instance *fi, int event, void *arg)
13401340
}
13411341

13421342
CTCM_PR_DBGDATA("ccwcda=0x%p data=0x%p\n",
1343-
(void *)(unsigned long)ch->ccw[1].cda,
1343+
(void *)(u64)dma32_to_u32(ch->ccw[1].cda),
13441344
ch->trans_skb->data);
13451345

13461346
ch->ccw[1].count = ch->trans_skb->len;

drivers/s390/net/ctcm_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1389,7 +1389,7 @@ static int add_channel(struct ccw_device *cdev, enum ctcm_channel_types type,
13891389
ch->ccw[15].cmd_code = CCW_CMD_WRITE;
13901390
ch->ccw[15].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
13911391
ch->ccw[15].count = TH_HEADER_LENGTH;
1392-
ch->ccw[15].cda = virt_to_phys(ch->discontact_th);
1392+
ch->ccw[15].cda = virt_to_dma32(ch->discontact_th);
13931393

13941394
ch->ccw[16].cmd_code = CCW_CMD_NOOP;
13951395
ch->ccw[16].flags = CCW_FLAG_SLI;

drivers/s390/net/ctcm_mpc.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1708,57 +1708,57 @@ static void mpc_action_side_xid(fsm_instance *fsm, void *arg, int side)
17081708
ch->ccw[9].cmd_code = CCW_CMD_WRITE;
17091709
ch->ccw[9].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17101710
ch->ccw[9].count = TH_HEADER_LENGTH;
1711-
ch->ccw[9].cda = virt_to_phys(ch->xid_th);
1711+
ch->ccw[9].cda = virt_to_dma32(ch->xid_th);
17121712

17131713
if (ch->xid == NULL)
17141714
goto done;
17151715
ch->ccw[10].cmd_code = CCW_CMD_WRITE;
17161716
ch->ccw[10].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17171717
ch->ccw[10].count = XID2_LENGTH;
1718-
ch->ccw[10].cda = virt_to_phys(ch->xid);
1718+
ch->ccw[10].cda = virt_to_dma32(ch->xid);
17191719

17201720
ch->ccw[11].cmd_code = CCW_CMD_READ;
17211721
ch->ccw[11].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17221722
ch->ccw[11].count = TH_HEADER_LENGTH;
1723-
ch->ccw[11].cda = virt_to_phys(ch->rcvd_xid_th);
1723+
ch->ccw[11].cda = virt_to_dma32(ch->rcvd_xid_th);
17241724

17251725
ch->ccw[12].cmd_code = CCW_CMD_READ;
17261726
ch->ccw[12].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17271727
ch->ccw[12].count = XID2_LENGTH;
1728-
ch->ccw[12].cda = virt_to_phys(ch->rcvd_xid);
1728+
ch->ccw[12].cda = virt_to_dma32(ch->rcvd_xid);
17291729

17301730
ch->ccw[13].cmd_code = CCW_CMD_READ;
1731-
ch->ccw[13].cda = virt_to_phys(ch->rcvd_xid_id);
1731+
ch->ccw[13].cda = virt_to_dma32(ch->rcvd_xid_id);
17321732

17331733
} else { /* side == YSIDE : mpc_action_yside_xid */
17341734
ch->ccw[9].cmd_code = CCW_CMD_READ;
17351735
ch->ccw[9].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17361736
ch->ccw[9].count = TH_HEADER_LENGTH;
1737-
ch->ccw[9].cda = virt_to_phys(ch->rcvd_xid_th);
1737+
ch->ccw[9].cda = virt_to_dma32(ch->rcvd_xid_th);
17381738

17391739
ch->ccw[10].cmd_code = CCW_CMD_READ;
17401740
ch->ccw[10].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17411741
ch->ccw[10].count = XID2_LENGTH;
1742-
ch->ccw[10].cda = virt_to_phys(ch->rcvd_xid);
1742+
ch->ccw[10].cda = virt_to_dma32(ch->rcvd_xid);
17431743

17441744
if (ch->xid_th == NULL)
17451745
goto done;
17461746
ch->ccw[11].cmd_code = CCW_CMD_WRITE;
17471747
ch->ccw[11].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17481748
ch->ccw[11].count = TH_HEADER_LENGTH;
1749-
ch->ccw[11].cda = virt_to_phys(ch->xid_th);
1749+
ch->ccw[11].cda = virt_to_dma32(ch->xid_th);
17501750

17511751
if (ch->xid == NULL)
17521752
goto done;
17531753
ch->ccw[12].cmd_code = CCW_CMD_WRITE;
17541754
ch->ccw[12].flags = CCW_FLAG_SLI | CCW_FLAG_CC;
17551755
ch->ccw[12].count = XID2_LENGTH;
1756-
ch->ccw[12].cda = virt_to_phys(ch->xid);
1756+
ch->ccw[12].cda = virt_to_dma32(ch->xid);
17571757

17581758
if (ch->xid_id == NULL)
17591759
goto done;
17601760
ch->ccw[13].cmd_code = CCW_CMD_WRITE;
1761-
ch->ccw[13].cda = virt_to_phys(ch->xid_id);
1761+
ch->ccw[13].cda = virt_to_dma32(ch->xid_id);
17621762

17631763
}
17641764
ch->ccw[13].flags = CCW_FLAG_SLI | CCW_FLAG_CC;

0 commit comments

Comments
 (0)