Skip to content

Commit 6bbe106

Browse files
nfrapradomathieupoirier
authored andcommitted
dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x
Commit ca23ecf ("remoteproc/mediatek: support L1TCM") added support for the l1tcm memory region on the MT8192 SCP, adding a new da_to_va callback that handles l1tcm while keeping the old one for back-compatibility with MT8183. However, since the mt8192 compatible was missing from the dt-binding, the accompanying dt-binding commit 503c64c ("dt-bindings: remoteproc: mediatek: add L1TCM memory region") mistakenly added this reg as if it were for mt8183. And later it became common to all platforms as their compatibles were added. Fix the dt-binding so that the l1tcm reg can be present only on the supported platforms: mt8192 and mt8195. Fixes: 503c64c ("dt-bindings: remoteproc: mediatek: add L1TCM memory region") Signed-off-by: Nícolas F. R. A. Prado <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mathieu Poirier <[email protected]>
1 parent be1de12 commit 6bbe106

File tree

1 file changed

+30
-14
lines changed

1 file changed

+30
-14
lines changed

Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml

Lines changed: 30 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,13 @@ properties:
2323

2424
reg:
2525
description:
26-
Should contain the address ranges for memory regions SRAM, CFG, and
27-
L1TCM.
26+
Should contain the address ranges for memory regions SRAM, CFG, and,
27+
on some platforms, L1TCM.
28+
minItems: 2
2829
maxItems: 3
2930

3031
reg-names:
32+
minItems: 2
3133
items:
3234
- const: sram
3335
- const: cfg
@@ -57,16 +59,30 @@ required:
5759
- reg
5860
- reg-names
5961

60-
if:
61-
properties:
62-
compatible:
63-
enum:
64-
- mediatek,mt8183-scp
65-
- mediatek,mt8192-scp
66-
then:
67-
required:
68-
- clocks
69-
- clock-names
62+
allOf:
63+
- if:
64+
properties:
65+
compatible:
66+
enum:
67+
- mediatek,mt8183-scp
68+
- mediatek,mt8192-scp
69+
then:
70+
required:
71+
- clocks
72+
- clock-names
73+
74+
- if:
75+
properties:
76+
compatible:
77+
enum:
78+
- mediatek,mt8183-scp
79+
- mediatek,mt8186-scp
80+
then:
81+
properties:
82+
reg:
83+
maxItems: 2
84+
reg-names:
85+
maxItems: 2
7086

7187
additionalProperties:
7288
type: object
@@ -86,10 +102,10 @@ additionalProperties:
86102

87103
examples:
88104
- |
89-
#include <dt-bindings/clock/mt8183-clk.h>
105+
#include <dt-bindings/clock/mt8192-clk.h>
90106
91107
scp@10500000 {
92-
compatible = "mediatek,mt8183-scp";
108+
compatible = "mediatek,mt8192-scp";
93109
reg = <0x10500000 0x80000>,
94110
<0x10700000 0x8000>,
95111
<0x10720000 0xe0000>;

0 commit comments

Comments
 (0)