mips/pci: remove redundant ret variable

Minghao Chi · tsbogend · commit 6bcfdc49f38e · 2022-01-05T09:54:08.000+01:00
Return value from rt3883_pci_r32() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: Minghao Chi &lt;chi.minghao@zte.com.cn&gt;
Signed-off-by: CGEL ZTE &lt;cgel.zte@gmail.com&gt;
Signed-off-by: Thomas Bogendoerfer &lt;tsbogend@alpha.franken.de&gt;
diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
@@ -102,14 +102,12 @@ static u32 rt3883_pci_read_cfg32(struct rt3883_pci_controller *rpc,
 			       unsigned func, unsigned reg)
 {
 	u32 address;
-	u32 ret;
 
 	address = rt3883_pci_get_cfgaddr(bus, slot, func, reg);
 
 	rt3883_pci_w32(rpc, address, RT3883_PCI_REG_CFGADDR);
-	ret = rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA);
 
-	return ret;
+	return rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA);
 }
 
 static void rt3883_pci_write_cfg32(struct rt3883_pci_controller *rpc,

Original file line number	Diff line number	Diff line change
`@@ -102,14 +102,12 @@ static u32 rt3883_pci_read_cfg32(struct rt3883_pci_controller *rpc,`
`102`	`102`	`unsigned func, unsigned reg)`
`103`	`103`	`{`
`104`	`104`	`u32 address;`
`105`		`- u32 ret;`
`106`	`105`
`107`	`106`	`address = rt3883_pci_get_cfgaddr(bus, slot, func, reg);`
`108`	`107`
`109`	`108`	`rt3883_pci_w32(rpc, address, RT3883_PCI_REG_CFGADDR);`
`110`		`- ret = rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA);`
`111`	`109`
`112`		`- return ret;`
	`110`	`+ return rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA);`
`113`	`111`	`}`
`114`	`112`
`115`	`113`	`static void rt3883_pci_write_cfg32(struct rt3883_pci_controller *rpc,`