Skip to content

Commit 6c056ae

Browse files
author
Al Viro
committed
libfs: kill empty_dir_getattr()
It's used only to initialize ->getattr in one inode_operations instance (empty_dir_inode_operations) and its behaviour had always been equivalent to what we get with NULL ->getattr. Just remove that initializer, along with empty_dir_getattr() itself. While we are at it, the same instance has ->permission initialized to generic_permission, which is what NULL ->permission ends up doing. Again, no point keeping it. Reviewed-by: Christian Brauner <[email protected]> Signed-off-by: Al Viro <[email protected]>
1 parent 95f567f commit 6c056ae

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

fs/libfs.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1711,15 +1711,6 @@ static struct dentry *empty_dir_lookup(struct inode *dir, struct dentry *dentry,
17111711
return ERR_PTR(-ENOENT);
17121712
}
17131713

1714-
static int empty_dir_getattr(struct mnt_idmap *idmap,
1715-
const struct path *path, struct kstat *stat,
1716-
u32 request_mask, unsigned int query_flags)
1717-
{
1718-
struct inode *inode = d_inode(path->dentry);
1719-
generic_fillattr(&nop_mnt_idmap, request_mask, inode, stat);
1720-
return 0;
1721-
}
1722-
17231714
static int empty_dir_setattr(struct mnt_idmap *idmap,
17241715
struct dentry *dentry, struct iattr *attr)
17251716
{
@@ -1733,9 +1724,7 @@ static ssize_t empty_dir_listxattr(struct dentry *dentry, char *list, size_t siz
17331724

17341725
static const struct inode_operations empty_dir_inode_operations = {
17351726
.lookup = empty_dir_lookup,
1736-
.permission = generic_permission,
17371727
.setattr = empty_dir_setattr,
1738-
.getattr = empty_dir_getattr,
17391728
.listxattr = empty_dir_listxattr,
17401729
};
17411730

0 commit comments

Comments
 (0)