Skip to content

Commit 6c0c7d2

Browse files
joergroedeltorvalds
authored andcommitted
mm/ioremap: track which page-table levels were modified
Track at which levels in the page-table entries were modified by ioremap_page_range(). After the page-table has been modified, use that information do decide whether the new arch_sync_kernel_mappings() needs to be called. The iounmap path re-uses vunmap(), which has already been taken care of. Signed-off-by: Joerg Roedel <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Acked-by: Andy Lutomirski <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Dave Hansen <[email protected]> Cc: "H . Peter Anvin" <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Matthew Wilcox (Oracle) <[email protected]> Cc: Michal Hocko <[email protected]> Cc: "Rafael J. Wysocki" <[email protected]> Cc: Steven Rostedt (VMware) <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Vlastimil Babka <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Linus Torvalds <[email protected]>
1 parent 2ba3e69 commit 6c0c7d2

File tree

1 file changed

+31
-15
lines changed

1 file changed

+31
-15
lines changed

lib/ioremap.c

Lines changed: 31 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,22 @@ static inline int ioremap_pmd_enabled(void) { return 0; }
6161
#endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */
6262

6363
static int ioremap_pte_range(pmd_t *pmd, unsigned long addr,
64-
unsigned long end, phys_addr_t phys_addr, pgprot_t prot)
64+
unsigned long end, phys_addr_t phys_addr, pgprot_t prot,
65+
pgtbl_mod_mask *mask)
6566
{
6667
pte_t *pte;
6768
u64 pfn;
6869

6970
pfn = phys_addr >> PAGE_SHIFT;
70-
pte = pte_alloc_kernel(pmd, addr);
71+
pte = pte_alloc_kernel_track(pmd, addr, mask);
7172
if (!pte)
7273
return -ENOMEM;
7374
do {
7475
BUG_ON(!pte_none(*pte));
7576
set_pte_at(&init_mm, addr, pte, pfn_pte(pfn, prot));
7677
pfn++;
7778
} while (pte++, addr += PAGE_SIZE, addr != end);
79+
*mask |= PGTBL_PTE_MODIFIED;
7880
return 0;
7981
}
8082

@@ -101,21 +103,24 @@ static int ioremap_try_huge_pmd(pmd_t *pmd, unsigned long addr,
101103
}
102104

103105
static inline int ioremap_pmd_range(pud_t *pud, unsigned long addr,
104-
unsigned long end, phys_addr_t phys_addr, pgprot_t prot)
106+
unsigned long end, phys_addr_t phys_addr, pgprot_t prot,
107+
pgtbl_mod_mask *mask)
105108
{
106109
pmd_t *pmd;
107110
unsigned long next;
108111

109-
pmd = pmd_alloc(&init_mm, pud, addr);
112+
pmd = pmd_alloc_track(&init_mm, pud, addr, mask);
110113
if (!pmd)
111114
return -ENOMEM;
112115
do {
113116
next = pmd_addr_end(addr, end);
114117

115-
if (ioremap_try_huge_pmd(pmd, addr, next, phys_addr, prot))
118+
if (ioremap_try_huge_pmd(pmd, addr, next, phys_addr, prot)) {
119+
*mask |= PGTBL_PMD_MODIFIED;
116120
continue;
121+
}
117122

118-
if (ioremap_pte_range(pmd, addr, next, phys_addr, prot))
123+
if (ioremap_pte_range(pmd, addr, next, phys_addr, prot, mask))
119124
return -ENOMEM;
120125
} while (pmd++, phys_addr += (next - addr), addr = next, addr != end);
121126
return 0;
@@ -144,21 +149,24 @@ static int ioremap_try_huge_pud(pud_t *pud, unsigned long addr,
144149
}
145150

146151
static inline int ioremap_pud_range(p4d_t *p4d, unsigned long addr,
147-
unsigned long end, phys_addr_t phys_addr, pgprot_t prot)
152+
unsigned long end, phys_addr_t phys_addr, pgprot_t prot,
153+
pgtbl_mod_mask *mask)
148154
{
149155
pud_t *pud;
150156
unsigned long next;
151157

152-
pud = pud_alloc(&init_mm, p4d, addr);
158+
pud = pud_alloc_track(&init_mm, p4d, addr, mask);
153159
if (!pud)
154160
return -ENOMEM;
155161
do {
156162
next = pud_addr_end(addr, end);
157163

158-
if (ioremap_try_huge_pud(pud, addr, next, phys_addr, prot))
164+
if (ioremap_try_huge_pud(pud, addr, next, phys_addr, prot)) {
165+
*mask |= PGTBL_PUD_MODIFIED;
159166
continue;
167+
}
160168

161-
if (ioremap_pmd_range(pud, addr, next, phys_addr, prot))
169+
if (ioremap_pmd_range(pud, addr, next, phys_addr, prot, mask))
162170
return -ENOMEM;
163171
} while (pud++, phys_addr += (next - addr), addr = next, addr != end);
164172
return 0;
@@ -187,21 +195,24 @@ static int ioremap_try_huge_p4d(p4d_t *p4d, unsigned long addr,
187195
}
188196

189197
static inline int ioremap_p4d_range(pgd_t *pgd, unsigned long addr,
190-
unsigned long end, phys_addr_t phys_addr, pgprot_t prot)
198+
unsigned long end, phys_addr_t phys_addr, pgprot_t prot,
199+
pgtbl_mod_mask *mask)
191200
{
192201
p4d_t *p4d;
193202
unsigned long next;
194203

195-
p4d = p4d_alloc(&init_mm, pgd, addr);
204+
p4d = p4d_alloc_track(&init_mm, pgd, addr, mask);
196205
if (!p4d)
197206
return -ENOMEM;
198207
do {
199208
next = p4d_addr_end(addr, end);
200209

201-
if (ioremap_try_huge_p4d(p4d, addr, next, phys_addr, prot))
210+
if (ioremap_try_huge_p4d(p4d, addr, next, phys_addr, prot)) {
211+
*mask |= PGTBL_P4D_MODIFIED;
202212
continue;
213+
}
203214

204-
if (ioremap_pud_range(p4d, addr, next, phys_addr, prot))
215+
if (ioremap_pud_range(p4d, addr, next, phys_addr, prot, mask))
205216
return -ENOMEM;
206217
} while (p4d++, phys_addr += (next - addr), addr = next, addr != end);
207218
return 0;
@@ -214,6 +225,7 @@ int ioremap_page_range(unsigned long addr,
214225
unsigned long start;
215226
unsigned long next;
216227
int err;
228+
pgtbl_mod_mask mask = 0;
217229

218230
might_sleep();
219231
BUG_ON(addr >= end);
@@ -222,13 +234,17 @@ int ioremap_page_range(unsigned long addr,
222234
pgd = pgd_offset_k(addr);
223235
do {
224236
next = pgd_addr_end(addr, end);
225-
err = ioremap_p4d_range(pgd, addr, next, phys_addr, prot);
237+
err = ioremap_p4d_range(pgd, addr, next, phys_addr, prot,
238+
&mask);
226239
if (err)
227240
break;
228241
} while (pgd++, phys_addr += (next - addr), addr = next, addr != end);
229242

230243
flush_cache_vmap(start, end);
231244

245+
if (mask & ARCH_PAGE_TABLE_SYNC_MASK)
246+
arch_sync_kernel_mappings(start, end);
247+
232248
return err;
233249
}
234250

0 commit comments

Comments
 (0)