Skip to content

Commit 6c17a9a

Browse files
krzklag-linaro
authored andcommitted
leds: 88pm860x: Simplify with scoped for each OF child loop
Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent 05c2f55 commit 6c17a9a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/leds/leds-88pm860x.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ static int pm860x_led_set(struct led_classdev *cdev,
115115
static int pm860x_led_dt_init(struct platform_device *pdev,
116116
struct pm860x_led *data)
117117
{
118-
struct device_node *nproot, *np;
118+
struct device_node *nproot;
119119
int iset = 0;
120120

121121
if (!dev_of_node(pdev->dev.parent))
@@ -125,12 +125,11 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
125125
dev_err(&pdev->dev, "failed to find leds node\n");
126126
return -ENODEV;
127127
}
128-
for_each_available_child_of_node(nproot, np) {
128+
for_each_available_child_of_node_scoped(nproot, np) {
129129
if (of_node_name_eq(np, data->name)) {
130130
of_property_read_u32(np, "marvell,88pm860x-iset",
131131
&iset);
132132
data->iset = PM8606_LED_CURRENT(iset);
133-
of_node_put(np);
134133
break;
135134
}
136135
}

0 commit comments

Comments
 (0)