Skip to content

Commit 6ce48b0

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: switch discard_policy.timeout to bool type
While checking discard timeout, we use specified type UMOUNT_DISCARD_TIMEOUT, so just replace doplicy.timeout with it, and switch doplicy.timeout to bool type. Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 8908e75 commit 6ce48b0

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

fs/f2fs/f2fs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,8 +330,8 @@ struct discard_policy {
330330
bool io_aware; /* issue discard in idle time */
331331
bool sync; /* submit discard with REQ_SYNC flag */
332332
bool ordered; /* issue discard by lba order */
333+
bool timeout; /* discard timeout for put_super */
333334
unsigned int granularity; /* discard granularity */
334-
int timeout; /* discard timeout for put_super */
335335
};
336336

337337
struct discard_cmd_control {

fs/f2fs/segment.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ static void __init_discard_policy(struct f2fs_sb_info *sbi,
10801080

10811081
dpolicy->max_requests = DEF_MAX_DISCARD_REQUEST;
10821082
dpolicy->io_aware_gran = MAX_PLIST_NUM;
1083-
dpolicy->timeout = 0;
1083+
dpolicy->timeout = false;
10841084

10851085
if (discard_type == DPOLICY_BG) {
10861086
dpolicy->min_interval = DEF_MIN_DISCARD_ISSUE_TIME;
@@ -1105,6 +1105,7 @@ static void __init_discard_policy(struct f2fs_sb_info *sbi,
11051105
dpolicy->io_aware = false;
11061106
/* we need to issue all to keep CP_TRIMMED_FLAG */
11071107
dpolicy->granularity = 1;
1108+
dpolicy->timeout = true;
11081109
}
11091110
}
11101111

@@ -1473,12 +1474,12 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi,
14731474
int i, issued = 0;
14741475
bool io_interrupted = false;
14751476

1476-
if (dpolicy->timeout != 0)
1477-
f2fs_update_time(sbi, dpolicy->timeout);
1477+
if (dpolicy->timeout)
1478+
f2fs_update_time(sbi, UMOUNT_DISCARD_TIMEOUT);
14781479

14791480
for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
1480-
if (dpolicy->timeout != 0 &&
1481-
f2fs_time_over(sbi, dpolicy->timeout))
1481+
if (dpolicy->timeout &&
1482+
f2fs_time_over(sbi, UMOUNT_DISCARD_TIMEOUT))
14821483
break;
14831484

14841485
if (i + 1 < dpolicy->granularity)
@@ -1499,8 +1500,8 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi,
14991500
list_for_each_entry_safe(dc, tmp, pend_list, list) {
15001501
f2fs_bug_on(sbi, dc->state != D_PREP);
15011502

1502-
if (dpolicy->timeout != 0 &&
1503-
f2fs_time_over(sbi, dpolicy->timeout))
1503+
if (dpolicy->timeout &&
1504+
f2fs_time_over(sbi, UMOUNT_DISCARD_TIMEOUT))
15041505
break;
15051506

15061507
if (dpolicy->io_aware && i < dpolicy->io_aware_gran &&
@@ -1679,7 +1680,6 @@ bool f2fs_issue_discard_timeout(struct f2fs_sb_info *sbi)
16791680

16801681
__init_discard_policy(sbi, &dpolicy, DPOLICY_UMOUNT,
16811682
dcc->discard_granularity);
1682-
dpolicy.timeout = UMOUNT_DISCARD_TIMEOUT;
16831683
__issue_discard_cmd(sbi, &dpolicy);
16841684
dropped = __drop_discard_cmd(sbi);
16851685

0 commit comments

Comments
 (0)