Skip to content

Commit 6d31fa6

Browse files
Lee Jonesgeertu
authored andcommitted
pinctrl: rza1: Demote some kerneldoc headers and fix others
Some description blocks are void of any description/documentation, others are missing 'struct' identifiers, there are also a couple of misspellings of function parameter names. Fix all of them. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/pinctrl-rza1.c:81: warning: cannot understand function prototype: 'struct rza1_bidir_pin ' drivers/pinctrl/pinctrl-rza1.c:90: warning: cannot understand function prototype: 'struct rza1_bidir_entry ' drivers/pinctrl/pinctrl-rza1.c:98: warning: cannot understand function prototype: 'struct rza1_swio_pin ' drivers/pinctrl/pinctrl-rza1.c:108: warning: cannot understand function prototype: 'struct rza1_swio_entry ' drivers/pinctrl/pinctrl-rza1.c:116: warning: cannot understand function prototype: 'struct rza1_pinmux_conf ' drivers/pinctrl/pinctrl-rza1.c:443: warning: cannot understand function prototype: 'struct rza1_mux_conf ' drivers/pinctrl/pinctrl-rza1.c:462: warning: cannot understand function prototype: 'struct rza1_port ' drivers/pinctrl/pinctrl-rza1.c:482: warning: cannot understand function prototype: 'struct rza1_pinctrl ' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'port' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'pin' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'func' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'port' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'reg' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'bit' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'set' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:672: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pin_mux_single' drivers/pinctrl/pinctrl-rza1.c:672: warning: Excess function parameter 'pinctrl' description in 'rza1_pin_mux_single' Signed-off-by: Lee Jones <[email protected]> Acked-by: Jacopo Mondi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Geert Uytterhoeven <[email protected]>
1 parent a5e8b53 commit 6d31fa6

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/pinctrl/pinctrl-rza1.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@
7575
* RZ/A1 pinmux flags
7676
*/
7777

78-
/**
78+
/*
7979
* rza1_bidir_pin - describe a single pin that needs bidir flag applied.
8080
*/
8181
struct rza1_bidir_pin {
8282
u8 pin: 4;
8383
u8 func: 4;
8484
};
8585

86-
/**
86+
/*
8787
* rza1_bidir_entry - describe a list of pins that needs bidir flag applied.
8888
* Each struct rza1_bidir_entry describes a port.
8989
*/
@@ -92,7 +92,7 @@ struct rza1_bidir_entry {
9292
const struct rza1_bidir_pin *pins;
9393
};
9494

95-
/**
95+
/*
9696
* rza1_swio_pin - describe a single pin that needs swio flag applied.
9797
*/
9898
struct rza1_swio_pin {
@@ -102,15 +102,15 @@ struct rza1_swio_pin {
102102
u16 input: 1;
103103
};
104104

105-
/**
105+
/*
106106
* rza1_swio_entry - describe a list of pins that needs swio flag applied
107107
*/
108108
struct rza1_swio_entry {
109109
const unsigned int npins;
110110
const struct rza1_swio_pin *pins;
111111
};
112112

113-
/**
113+
/*
114114
* rza1_pinmux_conf - group together bidir and swio pinmux flag tables
115115
*/
116116
struct rza1_pinmux_conf {
@@ -431,7 +431,7 @@ static const struct rza1_pinmux_conf rza1l_pmx_conf = {
431431
* RZ/A1 types
432432
*/
433433
/**
434-
* rza1_mux_conf - describes a pin multiplexing operation
434+
* struct rza1_mux_conf - describes a pin multiplexing operation
435435
*
436436
* @id: the pin identifier from 0 to RZA1_NPINS
437437
* @port: the port where pin sits on
@@ -450,7 +450,7 @@ struct rza1_mux_conf {
450450
};
451451

452452
/**
453-
* rza1_port - describes a pin port
453+
* struct rza1_port - describes a pin port
454454
*
455455
* This is mostly useful to lock register writes per-bank and not globally.
456456
*
@@ -467,12 +467,12 @@ struct rza1_port {
467467
};
468468

469469
/**
470-
* rza1_pinctrl - RZ pincontroller device
470+
* struct rza1_pinctrl - RZ pincontroller device
471471
*
472472
* @dev: parent device structure
473473
* @mutex: protect [pinctrl|pinmux]_generic functions
474474
* @base: logical address base
475-
* @nports: number of pin controller ports
475+
* @nport: number of pin controller ports
476476
* @ports: pin controller banks
477477
* @pins: pin array for pinctrl core
478478
* @desc: pincontroller desc for pinctrl core
@@ -536,7 +536,7 @@ static inline int rza1_pinmux_get_swio(unsigned int port,
536536
return -ENOENT;
537537
}
538538

539-
/**
539+
/*
540540
* rza1_pinmux_get_flags() - return pinmux flags associated to a pin
541541
*/
542542
static unsigned int rza1_pinmux_get_flags(unsigned int port, unsigned int pin,
@@ -566,7 +566,7 @@ static unsigned int rza1_pinmux_get_flags(unsigned int port, unsigned int pin,
566566
* RZ/A1 SoC operations
567567
*/
568568

569-
/**
569+
/*
570570
* rza1_set_bit() - un-locked set/clear a single bit in pin configuration
571571
* registers
572572
*/
@@ -664,7 +664,7 @@ static inline int rza1_pin_get(struct rza1_port *port, unsigned int pin)
664664
/**
665665
* rza1_pin_mux_single() - configure pin multiplexing on a single pin
666666
*
667-
* @pinctrl: RZ/A1 pin controller device
667+
* @rza1_pctl: RZ/A1 pin controller device
668668
* @mux_conf: pin multiplexing descriptor
669669
*/
670670
static int rza1_pin_mux_single(struct rza1_pinctrl *rza1_pctl,

0 commit comments

Comments
 (0)