Skip to content

Commit 6d3bd10

Browse files
Mani-Sadhasivamandersson
authored andcommitted
arm64: dts: qcom: sm8650: Fix the msi-map entries
While adding the GIC ITS MSI support, it was found that the msi-map entries needed to be swapped to receive MSIs from the endpoint. But later it was identified that the swapping was needed due to a bug in the Qualcomm PCIe controller driver. And since the bug is now fixed with commit bf79e33 ("PCI: qcom: Enable BDF to SID translation properly"), let's fix the msi-map entries also to reflect the actual mapping in the hardware. Fixes: a33a532 ("arm64: dts: qcom: sm8650: Use GIC-ITS for PCIe0 and PCIe1") Signed-off-by: Manivannan Sadhasivam <[email protected]> Acked-by: Neil Armstrong <[email protected]> Tested-by: Neil Armstrong <[email protected]> # on SM8650-QRD Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 98a953f commit 6d3bd10

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

arch/arm64/boot/dts/qcom/sm8650.dtsi

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2274,9 +2274,8 @@
22742274
interrupt-map-mask = <0 0 0 0x7>;
22752275
#interrupt-cells = <1>;
22762276

2277-
/* Entries are reversed due to the unusual ITS DeviceID encoding */
2278-
msi-map = <0x0 &gic_its 0x1401 0x1>,
2279-
<0x100 &gic_its 0x1400 0x1>;
2277+
msi-map = <0x0 &gic_its 0x1400 0x1>,
2278+
<0x100 &gic_its 0x1401 0x1>;
22802279
msi-map-mask = <0xff00>;
22812280

22822281
linux,pci-domain = <0>;
@@ -2402,9 +2401,8 @@
24022401
interrupt-map-mask = <0 0 0 0x7>;
24032402
#interrupt-cells = <1>;
24042403

2405-
/* Entries are reversed due to the unusual ITS DeviceID encoding */
2406-
msi-map = <0x0 &gic_its 0x1481 0x1>,
2407-
<0x100 &gic_its 0x1480 0x1>;
2404+
msi-map = <0x0 &gic_its 0x1480 0x1>,
2405+
<0x100 &gic_its 0x1481 0x1>;
24082406
msi-map-mask = <0xff00>;
24092407

24102408
linux,pci-domain = <1>;

0 commit comments

Comments
 (0)