Skip to content

Commit 6dd1de9

Browse files
Jiri Slaby (SUSE)gregkh
authored andcommitted
tty: mips_ejtag_fdc: fix one more u8 warning
The LKP robot complains about: drivers/tty/mips_ejtag_fdc.c:1224:31: error: incompatible pointer types passing 'const char *[1]' to parameter of type 'const u8 **' (aka 'const unsigned char **') Fix this by turning the missing pieces (fetch from kgdbfdc_wbuf) to u8 too. Note the filling part (kgdbfdc_write_char()) already receives and stores u8 to kgdbfdc_wbuf. Fixes: ce7cbd9 ("tty: mips_ejtag_fdc: use u8 for character pointers") Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Jiri Slaby (SUSE) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 4a495b9 commit 6dd1de9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/tty/mips_ejtag_fdc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,7 +1154,7 @@ static char kgdbfdc_rbuf[4];
11541154

11551155
/* write buffer to allow compaction */
11561156
static unsigned int kgdbfdc_wbuflen;
1157-
static char kgdbfdc_wbuf[4];
1157+
static u8 kgdbfdc_wbuf[4];
11581158

11591159
static void __iomem *kgdbfdc_setup(void)
11601160
{
@@ -1215,7 +1215,7 @@ static int kgdbfdc_read_char(void)
12151215
/* push an FDC word from write buffer to TX FIFO */
12161216
static void kgdbfdc_push_one(void)
12171217
{
1218-
const char *bufs[1] = { kgdbfdc_wbuf };
1218+
const u8 *bufs[1] = { kgdbfdc_wbuf };
12191219
struct fdc_word word;
12201220
void __iomem *regs;
12211221
unsigned int i;

0 commit comments

Comments
 (0)