Skip to content

Commit 6dfb077

Browse files
committed
HV: hv_balloon: fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: "K. Y. Srinivasan" <[email protected]> Cc: Haiyang Zhang <[email protected]> Cc: Wei Liu <[email protected]> Cc: Dexuan Cui <[email protected]> Fixes: d180e0a ("Drivers: hv: Create debugfs file with hyper-v balloon usage information") Cc: stable <[email protected]> Reviewed-by: Michael Kelley <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 9944028 commit 6dfb077

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hv/hv_balloon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1963,7 +1963,7 @@ static void hv_balloon_debugfs_init(struct hv_dynmem_device *b)
19631963

19641964
static void hv_balloon_debugfs_exit(struct hv_dynmem_device *b)
19651965
{
1966-
debugfs_remove(debugfs_lookup("hv-balloon", NULL));
1966+
debugfs_lookup_and_remove("hv-balloon", NULL);
19671967
}
19681968

19691969
#else

0 commit comments

Comments
 (0)