Skip to content

Commit 6e0f32d

Browse files
diederikdehaasmmind
authored andcommitted
arm64: dts: rockchip: Drop assigned-clock* from cpu nodes on rk3588
The assigned-clocks and assigned-clock-rates properties were moved from the scmi_clk node onto cpu nodes in commit 87810bd ("arm64: dts: rockchip: Fix SCMI assigned clocks on rk3588s") During review of v1 of that patch set, the following comment was made: why aren't you using OPP tables to define CPU frequencies. Assigned-clocks looks like a temporary hack because you haven't done proper OPP tables. Some time later, proper OPP tables for rk3588 were added in commit 276856d ("arm64: dts: rockchip: Add OPP data for CPU cores on RK3588") So this 'temporary hack' is no longer needed. Dropping it fixes the following dtb validation issues: cpu@0: Unevaluated properties are not allowed ('assigned-clock-rates', 'assigned-clocks' were unexpected) cpu@400: Unevaluated properties are not allowed ('assigned-clock-rates', 'assigned-clocks' were unexpected) cpu@600: Unevaluated properties are not allowed ('assigned-clock-rates', 'assigned-clocks' were unexpected) Link: https://lore.kernel.org/linux-rockchip/CAL_JsqL_EogoKOQ1xwU75=rJSC4o7yV3Jej4vadtacX2Pt3-hw@mail.gmail.com/ Signed-off-by: Diederik de Haas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent ede1fa1 commit 6e0f32d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@
9696
enable-method = "psci";
9797
capacity-dmips-mhz = <530>;
9898
clocks = <&scmi_clk SCMI_CLK_CPUL>;
99-
assigned-clocks = <&scmi_clk SCMI_CLK_CPUL>;
100-
assigned-clock-rates = <816000000>;
10199
cpu-idle-states = <&CPU_SLEEP>;
102100
i-cache-size = <32768>;
103101
i-cache-line-size = <64>;
@@ -174,8 +172,6 @@
174172
enable-method = "psci";
175173
capacity-dmips-mhz = <1024>;
176174
clocks = <&scmi_clk SCMI_CLK_CPUB01>;
177-
assigned-clocks = <&scmi_clk SCMI_CLK_CPUB01>;
178-
assigned-clock-rates = <816000000>;
179175
cpu-idle-states = <&CPU_SLEEP>;
180176
i-cache-size = <65536>;
181177
i-cache-line-size = <64>;
@@ -214,8 +210,6 @@
214210
enable-method = "psci";
215211
capacity-dmips-mhz = <1024>;
216212
clocks = <&scmi_clk SCMI_CLK_CPUB23>;
217-
assigned-clocks = <&scmi_clk SCMI_CLK_CPUB23>;
218-
assigned-clock-rates = <816000000>;
219213
cpu-idle-states = <&CPU_SLEEP>;
220214
i-cache-size = <65536>;
221215
i-cache-line-size = <64>;

0 commit comments

Comments
 (0)