@@ -30,6 +30,7 @@ Rules on what kind of patches are accepted, and which ones are not, into the
30
30
- No "trivial" fixes without benefit for users (spelling changes, whitespace
31
31
cleanups, etc).
32
32
33
+
33
34
Procedure for submitting patches to the -stable tree
34
35
----------------------------------------------------
35
36
@@ -41,33 +42,40 @@ Procedure for submitting patches to the -stable tree
41
42
42
43
There are three options to submit a change to -stable trees:
43
44
44
- :ref: `option_1 ` is **strongly ** preferred, is the easiest and most common.
45
- :ref: `option_2 ` and :ref: `option_3 ` are more useful if the patch isn't deemed
46
- worthy at the time it is applied to a public git tree (for instance, because
47
- it deserves more regression testing first). :ref: `option_3 ` is especially
48
- useful if the original upstream patch needs to be backported (for example
49
- the backport needs some special handling due to e.g. API changes).
45
+ 1. Add a 'stable tag' to the description of a patch you then submit for
46
+ mainline inclusion.
47
+ 2. Ask the stable team to pick up a patch already mainlined.
48
+ 3. Submit a patch to the stable team that is equivalent to a change already
49
+ mainlined.
50
+
51
+ The sections below describe each of the options in more detail.
52
+
53
+ :ref: `option_1 ` is **strongly ** preferred, it is the easiest and most common.
54
+ :ref: `option_2 ` is mainly meant for changes where backporting was not considered
55
+ at the time of submission. :ref: `option_3 ` is an alternative to the two earlier
56
+ options for cases where a mainlined patch needs adjustments to apply in older
57
+ series (for example due to API changes).
50
58
51
59
.. _option_1 :
52
60
53
61
Option 1
54
62
********
55
63
56
- To have the patch automatically included in the stable tree, add the tag
64
+ To have a patch you submit for mainline inclusion later automatically picked up
65
+ for stable trees, add the tag
57
66
58
67
.. code-block :: none
59
68
60
69
61
70
62
- in the sign-off area. Once the patch is merged it will be applied to the
71
+ in the sign-off area. Once the patch is mainlined it will be applied to the
63
72
stable tree without anything else needing to be done by the author or
64
73
subsystem maintainer.
65
74
66
- To accompany a note to the stable team, use a shell-style inline comment (see
67
- below for details) :
75
+ To sent additional instructions to the stable team, use a shell-style inline
76
+ comment :
68
77
69
- * Additionally, some patches submitted via :ref: `option_1 ` may have additional
70
- patch prerequisites which can be cherry-picked. This can be specified in the
78
+ * To specify any additional patch prerequisites for cherry picking use the
71
79
following format in the sign-off area:
72
80
73
81
.. code-block :: none
@@ -87,8 +95,8 @@ below for details):
87
95
git cherry-pick fd21073
88
96
git cherry-pick <this commit>
89
97
90
- * Also, some patches may have kernel version prerequisites. This can be
91
- specified in the following format in the sign-off area:
98
+ * For patches that may have kernel version prerequisites specify them using
99
+ the following format in the sign-off area:
92
100
93
101
.. code-block :: none
94
102
@@ -102,27 +110,28 @@ below for details):
102
110
103
111
For each "-stable" tree starting with the specified version.
104
112
105
- * To delay pick up of patches submitted via :ref: `option_1 `, use the following
106
- format:
113
+ Note, such tagging is unnecessary if the stable team can derive the
114
+ appropriate versions from Fixes: tags.
115
+
116
+ * To delay pick up of patches, use the following format:
107
117
108
118
.. code-block :: none
109
119
110
120
Cc: <[email protected] > # after 4 weeks in mainline
111
121
112
- * For any other requests related to patches submitted via :ref: `option_1 `, just
113
- add a note to the stable tag. This for example can be used to point out known
114
- problems:
122
+ * For any other requests, just add a note to the stable tag. This for example
123
+ can be used to point out known problems:
115
124
116
125
.. code-block :: none
117
126
118
- Cc: <[email protected] > # see patch description, needs adjustments for > = 6.3
127
+ Cc: <[email protected] > # see patch description, needs adjustments for < = 6.3
119
128
120
129
.. _option_2 :
121
130
122
131
Option 2
123
132
********
124
133
125
- After the patch has been merged to Linus' tree , send an email to
134
+ If the patch already has been merged to mainline , send an email to
126
135
[email protected] containing the subject of the patch, the commit ID,
127
136
why you think it should be applied, and what kernel version you wish it to
128
137
be applied to.
@@ -133,16 +142,9 @@ Option 3
133
142
********
134
143
135
144
Send the patch, after verifying that it follows the above rules, to
136
- [email protected] . You must note the upstream commit ID in the
137
- changelog of your submission, as well as the kernel version you wish
138
- it to be applied to.
139
-
140
- Note that for :ref: `option_3 `, if the patch deviates from the original
141
- upstream patch (for example because it had to be backported) this must be very
142
- clearly documented and justified in the patch description.
143
-
144
- The upstream commit ID must be specified with a separate line above the commit
145
- text, like this:
145
+ [email protected] and mention the kernel version you wish it to be applied
146
+ to. When doing so, you must note the upstream commit ID in the changelog of your
147
+ submission with a separate line above the commit text, like this:
146
148
147
149
.. code-block :: none
148
150
@@ -154,12 +156,17 @@ or alternatively:
154
156
155
157
[ Upstream commit <sha1> ]
156
158
159
+ If the submitted patch deviates from the original upstream patch (for example
160
+ because it had to be adjusted for the older API), this must be very clearly
161
+ documented and justified in the patch description.
162
+
163
+
157
164
Following the submission
158
165
------------------------
159
166
160
167
The sender will receive an ACK when the patch has been accepted into the
161
168
queue, or a NAK if the patch is rejected. This response might take a few
162
- days, according to the developer's schedules.
169
+ days, according to the schedules of the stable team members .
163
170
164
171
If accepted, the patch will be added to the -stable queue, for review by other
165
172
developers and by the relevant subsystem maintainer.
@@ -191,6 +198,7 @@ Review cycle
191
198
security kernel team, and not go through the normal review cycle.
192
199
Contact the kernel security team for more details on this procedure.
193
200
201
+
194
202
Trees
195
203
-----
196
204
0 commit comments