Skip to content

Commit 6e1b4bd

Browse files
ytcooderostedt
authored andcommitted
tracing: Remove duplicate warnings when calling trace_create_file()
Since the same warning message is already printed in the trace_create_file() function, there is no need to print it again. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Yuntao Wang <[email protected]> Signed-off-by: Steven Rostedt <[email protected]>
1 parent dfea08a commit 6e1b4bd

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

kernel/trace/trace_events.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3461,10 +3461,8 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
34613461

34623462
entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
34633463
tr, &ftrace_tr_enable_fops);
3464-
if (!entry) {
3465-
pr_warn("Could not create tracefs 'enable' entry\n");
3464+
if (!entry)
34663465
return -ENOMEM;
3467-
}
34683466

34693467
/* There are not as crucial, just warn if they are not created */
34703468

@@ -3480,17 +3478,13 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
34803478
pr_warn("Could not create tracefs 'set_event_notrace_pid' entry\n");
34813479

34823480
/* ring buffer internal formats */
3483-
entry = trace_create_file("header_page", TRACE_MODE_READ, d_events,
3481+
trace_create_file("header_page", TRACE_MODE_READ, d_events,
34843482
ring_buffer_print_page_header,
34853483
&ftrace_show_header_fops);
3486-
if (!entry)
3487-
pr_warn("Could not create tracefs 'header_page' entry\n");
34883484

3489-
entry = trace_create_file("header_event", TRACE_MODE_READ, d_events,
3485+
trace_create_file("header_event", TRACE_MODE_READ, d_events,
34903486
ring_buffer_print_entry_header,
34913487
&ftrace_show_header_fops);
3492-
if (!entry)
3493-
pr_warn("Could not create tracefs 'header_event' entry\n");
34943488

34953489
tr->event_dir = d_events;
34963490

0 commit comments

Comments
 (0)