Skip to content

Commit 6e40620

Browse files
kragnizt-8ch
authored andcommitted
selftests/nolibc: use O_RDONLY flag instead of 0
This doesn't matter much, but is what the standard says. Signed-off-by: Louis Taylor <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Thomas Weißschuh <[email protected]>
1 parent 00e03fe commit 6e40620

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/nolibc/nolibc-test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,8 +1130,8 @@ int run_syscall(int min, int max)
11301130
CASE_TEST(mmap_bad); EXPECT_PTRER(1, mmap(NULL, 0, PROT_READ, MAP_PRIVATE, 0, 0), MAP_FAILED, EINVAL); break;
11311131
CASE_TEST(munmap_bad); EXPECT_SYSER(1, munmap(NULL, 0), -1, EINVAL); break;
11321132
CASE_TEST(mmap_munmap_good); EXPECT_SYSZR(1, test_mmap_munmap()); break;
1133-
CASE_TEST(open_tty); EXPECT_SYSNE(1, tmp = open("/dev/null", 0), -1); if (tmp != -1) close(tmp); break;
1134-
CASE_TEST(open_blah); EXPECT_SYSER(1, tmp = open("/proc/self/blah", 0), -1, ENOENT); if (tmp != -1) close(tmp); break;
1133+
CASE_TEST(open_tty); EXPECT_SYSNE(1, tmp = open("/dev/null", O_RDONLY), -1); if (tmp != -1) close(tmp); break;
1134+
CASE_TEST(open_blah); EXPECT_SYSER(1, tmp = open("/proc/self/blah", O_RDONLY), -1, ENOENT); if (tmp != -1) close(tmp); break;
11351135
CASE_TEST(openat_dir); EXPECT_SYSZR(1, test_openat()); break;
11361136
CASE_TEST(pipe); EXPECT_SYSZR(1, test_pipe()); break;
11371137
CASE_TEST(poll_null); EXPECT_SYSZR(1, poll(NULL, 0, 0)); break;

0 commit comments

Comments
 (0)