Skip to content

Commit 6e57188

Browse files
keyonjietiwai
authored andcommitted
ALSA: hda: Update kernel-doc function parameter descriptions
Make W=1 throws a lot of warnings, with multiple misalignments between function params and their descriptions. Signed-off-by: Keyon Jie <[email protected]> Signed-off-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 1a462be commit 6e57188

File tree

8 files changed

+28
-18
lines changed

8 files changed

+28
-18
lines changed

sound/hda/ext/hdac_ext_bus.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ MODULE_LICENSE("GPL v2");
1919

2020
/**
2121
* snd_hdac_ext_bus_init - initialize a HD-audio extended bus
22-
* @ebus: the pointer to extended bus object
22+
* @bus: the pointer to HDAC bus object
2323
* @dev: device pointer
2424
* @ops: bus verb operators
25-
* default ops
25+
* @ext_ops: operators used for ASoC HDA codec drivers
2626
*
2727
* Returns 0 if successful, or a negative error code.
2828
*/
@@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_init);
5151

5252
/**
5353
* snd_hdac_ext_bus_exit - clean up a HD-audio extended bus
54-
* @ebus: the pointer to extended bus object
54+
* @bus: the pointer to HDAC bus object
5555
*/
5656
void snd_hdac_ext_bus_exit(struct hdac_bus *bus)
5757
{
@@ -67,8 +67,9 @@ static void default_release(struct device *dev)
6767

6868
/**
6969
* snd_hdac_ext_bus_device_init - initialize the HDA extended codec base device
70-
* @ebus: hdac extended bus to attach to
70+
* @bus: hdac bus to attach to
7171
* @addr: codec address
72+
* @hdev: hdac device to init
7273
*
7374
* Returns zero for success or a negative error code.
7475
*/
@@ -114,7 +115,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_exit);
114115
/**
115116
* snd_hdac_ext_bus_device_remove - remove HD-audio extended codec base devices
116117
*
117-
* @ebus: HD-audio extended bus
118+
* @bus: the pointer to HDAC bus object
118119
*/
119120
void snd_hdac_ext_bus_device_remove(struct hdac_bus *bus)
120121
{

sound/hda/ext/hdac_ext_controller.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
/**
3030
* snd_hdac_ext_bus_ppcap_enable - enable/disable processing pipe capability
31-
* @ebus: HD-audio extended core bus
31+
* @bus: the pointer to HDAC bus object
3232
* @enable: flag to turn on/off the capability
3333
*/
3434
void snd_hdac_ext_bus_ppcap_enable(struct hdac_bus *bus, bool enable)
@@ -50,7 +50,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_ppcap_enable);
5050

5151
/**
5252
* snd_hdac_ext_bus_ppcap_int_enable - ppcap interrupt enable/disable
53-
* @ebus: HD-audio extended core bus
53+
* @bus: the pointer to HDAC bus object
5454
* @enable: flag to enable/disable interrupt
5555
*/
5656
void snd_hdac_ext_bus_ppcap_int_enable(struct hdac_bus *bus, bool enable)
@@ -77,7 +77,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_ppcap_int_enable);
7777

7878
/**
7979
* snd_hdac_ext_bus_get_ml_capabilities - get multilink capability
80-
* @ebus: HD-audio extended core bus
80+
* @bus: the pointer to HDAC bus object
8181
*
8282
* This will parse all links and read the mlink capabilities and add them
8383
* in hlink_list of extended hdac bus
@@ -117,7 +117,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_get_ml_capabilities);
117117
/**
118118
* snd_hdac_link_free_all- free hdac extended link objects
119119
*
120-
* @ebus: HD-audio ext core bus
120+
* @bus: the pointer to HDAC bus object
121121
*/
122122

123123
void snd_hdac_link_free_all(struct hdac_bus *bus)
@@ -134,7 +134,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_link_free_all);
134134

135135
/**
136136
* snd_hdac_ext_bus_get_link_index - get link based on codec name
137-
* @ebus: HD-audio extended core bus
137+
* @bus: the pointer to HDAC bus object
138138
* @codec_name: codec name
139139
*/
140140
struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_bus *bus,
@@ -211,7 +211,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_power_down);
211211

212212
/**
213213
* snd_hdac_ext_bus_link_power_up_all -power up all hda link
214-
* @ebus: HD-audio extended bus
214+
* @bus: the pointer to HDAC bus object
215215
*/
216216
int snd_hdac_ext_bus_link_power_up_all(struct hdac_bus *bus)
217217
{
@@ -232,7 +232,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_power_up_all);
232232

233233
/**
234234
* snd_hdac_ext_bus_link_power_down_all -power down all hda link
235-
* @ebus: HD-audio extended bus
235+
* @bus: the pointer to HDAC bus object
236236
*/
237237
int snd_hdac_ext_bus_link_power_down_all(struct hdac_bus *bus)
238238
{

sound/hda/ext/hdac_ext_stream.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,6 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_set_dpibr);
530530

531531
/**
532532
* snd_hdac_ext_stream_set_lpib - sets the lpib value of a stream
533-
* @bus: HD-audio core bus
534533
* @stream: hdac_ext_stream
535534
* @value: lpib value to set
536535
*/

sound/hda/hdac_bus.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ static const struct hdac_bus_ops default_ops = {
2222
/**
2323
* snd_hdac_bus_init - initialize a HD-audio bas bus
2424
* @bus: the pointer to bus object
25+
* @dev: device pointer
2526
* @ops: bus verb operators
2627
*
2728
* Returns 0 if successful, or a negative error code.
@@ -64,6 +65,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_bus_exit);
6465
/**
6566
* snd_hdac_bus_exec_verb - execute a HD-audio verb on the given bus
6667
* @bus: bus object
68+
* @addr: the HDAC device address
6769
* @cmd: HD-audio encoded verb
6870
* @res: pointer to store the response, NULL if performing asynchronously
6971
*
@@ -84,6 +86,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_bus_exec_verb);
8486
/**
8587
* snd_hdac_bus_exec_verb_unlocked - unlocked version
8688
* @bus: bus object
89+
* @addr: the HDAC device address
8790
* @cmd: HD-audio encoded verb
8891
* @res: pointer to store the response, NULL if performing asynchronously
8992
*

sound/hda/hdac_component.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_acomp_register_notifier);
262262
/**
263263
* snd_hdac_acomp_init - Initialize audio component
264264
* @bus: HDA core bus
265+
* @aops: audio component ops
265266
* @match_master: match function for finding components
266267
* @extra_size: Extra bytes to allocate
267268
*

sound/hda/hdac_controller.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_bus_stop_chip);
561561
* snd_hdac_bus_handle_stream_irq - interrupt handler for streams
562562
* @bus: HD-audio core bus
563563
* @status: INTSTS register value
564-
* @ask: callback to be called for woken streams
564+
* @ack: callback to be called for woken streams
565565
*
566566
* Returns the bits of handled streams, or zero if no stream is handled.
567567
*/

sound/hda/hdac_device.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_device_exit);
135135

136136
/**
137137
* snd_hdac_device_register - register the hd-audio codec base device
138-
* codec: the device to register
138+
* @codec: the device to register
139139
*/
140140
int snd_hdac_device_register(struct hdac_device *codec)
141141
{
@@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_device_register);
158158

159159
/**
160160
* snd_hdac_device_unregister - unregister the hd-audio codec base device
161-
* codec: the device to unregister
161+
* @codec: the device to unregister
162162
*/
163163
void snd_hdac_device_unregister(struct hdac_device *codec)
164164
{
@@ -281,6 +281,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_read);
281281

282282
/**
283283
* _snd_hdac_read_parm - read a parmeter
284+
* @codec: the codec object
285+
* @nid: NID to read a parameter
286+
* @parm: parameter to read
287+
* @res: pointer to store the read value
284288
*
285289
* This function returns zero or an error unlike snd_hdac_read_parm().
286290
*/
@@ -1062,9 +1066,9 @@ EXPORT_SYMBOL_GPL(snd_hdac_check_power_state);
10621066
* snd_hdac_sync_power_state - wait until actual power state matches
10631067
* with the target state
10641068
*
1065-
* @hdac: the HDAC device
1069+
* @codec: the HDAC device
10661070
* @nid: NID to send the command
1067-
* @target_state: target state to check for
1071+
* @power_state: target power state to wait for
10681072
*
10691073
* Return power state or PS_ERROR if codec rejects GET verb.
10701074
*/

sound/hda/hdac_stream.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,9 @@ EXPORT_SYMBOL_GPL(snd_hdac_stream_timecounter_init);
590590
/**
591591
* snd_hdac_stream_sync_trigger - turn on/off stream sync register
592592
* @azx_dev: HD-audio core stream (master stream)
593+
* @set: true = set, false = clear
593594
* @streams: bit flags of streams to sync
595+
* @reg: the stream sync register address
594596
*/
595597
void snd_hdac_stream_sync_trigger(struct hdac_stream *azx_dev, bool set,
596598
unsigned int streams, unsigned int reg)

0 commit comments

Comments
 (0)