Skip to content

Commit 6eb2aad

Browse files
committed
drm/xe: Move hw_engine_fini to devm managed
Kernel BOs are destroyed with GGTT mappings, this is hardware interaction so use devm. Signed-off-by: Matthew Brost <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a323782 commit 6eb2aad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/xe/xe_hw_engine.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ static const struct engine_info engine_infos[] = {
267267
},
268268
};
269269

270-
static void hw_engine_fini(struct drm_device *drm, void *arg)
270+
static void hw_engine_fini(void *arg)
271271
{
272272
struct xe_hw_engine *hwe = arg;
273273

@@ -585,7 +585,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,
585585
if (xe->info.has_usm && hwe->class == XE_ENGINE_CLASS_COPY)
586586
gt->usm.reserved_bcs_instance = hwe->instance;
587587

588-
return drmm_add_action_or_reset(&xe->drm, hw_engine_fini, hwe);
588+
return devm_add_action_or_reset(xe->drm.dev, hw_engine_fini, hwe);
589589

590590
err_kernel_lrc:
591591
xe_lrc_put(hwe->kernel_lrc);

0 commit comments

Comments
 (0)