Skip to content

Commit 6f039cc

Browse files
apaszkieliu-song-6
authored andcommitted
md/raid5: rename wait_for_overlap to wait_for_reshape
The only remaining uses of wait_for_overlap are related to reshape so rename it accordingly. Signed-off-by: Artur Paszkiewicz <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Song Liu <[email protected]>
1 parent 0e4aac7 commit 6f039cc

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

drivers/md/raid5.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5257,7 +5257,7 @@ static void handle_stripe(struct stripe_head *sh)
52575257
} else if (s.expanded && !sh->reconstruct_state && s.locked == 0) {
52585258
clear_bit(STRIPE_EXPAND_READY, &sh->state);
52595259
atomic_dec(&conf->reshape_stripes);
5260-
wake_up(&conf->wait_for_overlap);
5260+
wake_up(&conf->wait_for_reshape);
52615261
md_done_sync(conf->mddev, RAID5_STRIPE_SECTORS(conf), 1);
52625262
}
52635263

@@ -6148,7 +6148,7 @@ static bool raid5_make_request(struct mddev *mddev, struct bio * bi)
61486148
logical_sector = raid5_bio_lowest_chunk_sector(conf, bi);
61496149
on_wq = false;
61506150
} else {
6151-
add_wait_queue(&conf->wait_for_overlap, &wait);
6151+
add_wait_queue(&conf->wait_for_reshape, &wait);
61526152
on_wq = true;
61536153
}
61546154
s = (logical_sector - ctx.first_sector) >> RAID5_STRIPE_SHIFT(conf);
@@ -6189,7 +6189,7 @@ static bool raid5_make_request(struct mddev *mddev, struct bio * bi)
61896189
(s << RAID5_STRIPE_SHIFT(conf));
61906190
}
61916191
if (unlikely(on_wq))
6192-
remove_wait_queue(&conf->wait_for_overlap, &wait);
6192+
remove_wait_queue(&conf->wait_for_reshape, &wait);
61936193

61946194
if (ctx.batch_last)
61956195
raid5_release_stripe(ctx.batch_last);
@@ -6342,7 +6342,7 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, int *sk
63426342
: (safepos < writepos && readpos > writepos)) ||
63436343
time_after(jiffies, conf->reshape_checkpoint + 10*HZ)) {
63446344
/* Cannot proceed until we've updated the superblock... */
6345-
wait_event(conf->wait_for_overlap,
6345+
wait_event(conf->wait_for_reshape,
63466346
atomic_read(&conf->reshape_stripes)==0
63476347
|| test_bit(MD_RECOVERY_INTR, &mddev->recovery));
63486348
if (atomic_read(&conf->reshape_stripes) != 0)
@@ -6368,7 +6368,7 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, int *sk
63686368
spin_lock_irq(&conf->device_lock);
63696369
conf->reshape_safe = mddev->reshape_position;
63706370
spin_unlock_irq(&conf->device_lock);
6371-
wake_up(&conf->wait_for_overlap);
6371+
wake_up(&conf->wait_for_reshape);
63726372
sysfs_notify_dirent_safe(mddev->sysfs_completed);
63736373
}
63746374

@@ -6451,7 +6451,7 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, int *sk
64516451
(sector_nr - mddev->curr_resync_completed) * 2
64526452
>= mddev->resync_max - mddev->curr_resync_completed) {
64536453
/* Cannot proceed until we've updated the superblock... */
6454-
wait_event(conf->wait_for_overlap,
6454+
wait_event(conf->wait_for_reshape,
64556455
atomic_read(&conf->reshape_stripes) == 0
64566456
|| test_bit(MD_RECOVERY_INTR, &mddev->recovery));
64576457
if (atomic_read(&conf->reshape_stripes) != 0)
@@ -6477,7 +6477,7 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, int *sk
64776477
spin_lock_irq(&conf->device_lock);
64786478
conf->reshape_safe = mddev->reshape_position;
64796479
spin_unlock_irq(&conf->device_lock);
6480-
wake_up(&conf->wait_for_overlap);
6480+
wake_up(&conf->wait_for_reshape);
64816481
sysfs_notify_dirent_safe(mddev->sysfs_completed);
64826482
}
64836483
ret:
@@ -6512,7 +6512,7 @@ static inline sector_t raid5_sync_request(struct mddev *mddev, sector_t sector_n
65126512
}
65136513

65146514
/* Allow raid5_quiesce to complete */
6515-
wait_event(conf->wait_for_overlap, conf->quiesce != 2);
6515+
wait_event(conf->wait_for_reshape, conf->quiesce != 2);
65166516

65176517
if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
65186518
return reshape_request(mddev, sector_nr, skipped);
@@ -7498,7 +7498,7 @@ static struct r5conf *setup_conf(struct mddev *mddev)
74987498

74997499
init_waitqueue_head(&conf->wait_for_quiescent);
75007500
init_waitqueue_head(&conf->wait_for_stripe);
7501-
init_waitqueue_head(&conf->wait_for_overlap);
7501+
init_waitqueue_head(&conf->wait_for_reshape);
75027502
INIT_LIST_HEAD(&conf->handle_list);
75037503
INIT_LIST_HEAD(&conf->loprio_list);
75047504
INIT_LIST_HEAD(&conf->hold_list);
@@ -8557,7 +8557,7 @@ static void end_reshape(struct r5conf *conf)
85578557
!test_bit(In_sync, &rdev->flags))
85588558
rdev->recovery_offset = MaxSector;
85598559
spin_unlock_irq(&conf->device_lock);
8560-
wake_up(&conf->wait_for_overlap);
8560+
wake_up(&conf->wait_for_reshape);
85618561

85628562
mddev_update_io_opt(conf->mddev,
85638563
conf->raid_disks - conf->max_degraded);
@@ -8621,13 +8621,13 @@ static void raid5_quiesce(struct mddev *mddev, int quiesce)
86218621
conf->quiesce = 1;
86228622
unlock_all_device_hash_locks_irq(conf);
86238623
/* allow reshape to continue */
8624-
wake_up(&conf->wait_for_overlap);
8624+
wake_up(&conf->wait_for_reshape);
86258625
} else {
86268626
/* re-enable writes */
86278627
lock_all_device_hash_locks_irq(conf);
86288628
conf->quiesce = 0;
86298629
wake_up(&conf->wait_for_quiescent);
8630-
wake_up(&conf->wait_for_overlap);
8630+
wake_up(&conf->wait_for_reshape);
86318631
unlock_all_device_hash_locks_irq(conf);
86328632
}
86338633
log_quiesce(conf, quiesce);
@@ -8946,7 +8946,7 @@ static void raid5_prepare_suspend(struct mddev *mddev)
89468946
{
89478947
struct r5conf *conf = mddev->private;
89488948

8949-
wake_up(&conf->wait_for_overlap);
8949+
wake_up(&conf->wait_for_reshape);
89508950
}
89518951

89528952
static struct md_personality raid6_personality =

drivers/md/raid5.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ struct r5conf {
668668
struct llist_head released_stripes;
669669
wait_queue_head_t wait_for_quiescent;
670670
wait_queue_head_t wait_for_stripe;
671-
wait_queue_head_t wait_for_overlap;
671+
wait_queue_head_t wait_for_reshape;
672672
unsigned long cache_state;
673673
struct shrinker *shrinker;
674674
int pool_size; /* number of disks in stripeheads in pool */

0 commit comments

Comments
 (0)