Skip to content

Commit 6f5c27f

Browse files
grygoriySdavem330
authored andcommitted
net: ethernet: ti: am65-cpsw-nuss: fix irqs type
The K3 INTA driver, which is source TX/RX IRQs for CPSW NUSS, defines IRQs triggering type as EDGE by default, but triggering type for CPSW NUSS TX/RX IRQs has to be LEVEL as the EDGE triggering type may cause unnecessary IRQs triggering and NAPI scheduling for empty queues. It was discovered with RT-kernel. Fix it by explicitly specifying CPSW NUSS TX/RX IRQ type as IRQF_TRIGGER_HIGH. Fixes: 93a7653 ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Signed-off-by: Grygorii Strashko <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0735ccc commit 6f5c27f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/net/ethernet/ti/am65-cpsw-nuss.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1719,7 +1719,8 @@ static int am65_cpsw_nuss_ndev_add_napi_2g(struct am65_cpsw_common *common)
17191719

17201720
ret = devm_request_irq(dev, tx_chn->irq,
17211721
am65_cpsw_nuss_tx_irq,
1722-
0, tx_chn->tx_chn_name, tx_chn);
1722+
IRQF_TRIGGER_HIGH,
1723+
tx_chn->tx_chn_name, tx_chn);
17231724
if (ret) {
17241725
dev_err(dev, "failure requesting tx%u irq %u, %d\n",
17251726
tx_chn->id, tx_chn->irq, ret);
@@ -1744,7 +1745,7 @@ static int am65_cpsw_nuss_ndev_reg_2g(struct am65_cpsw_common *common)
17441745

17451746
ret = devm_request_irq(dev, common->rx_chns.irq,
17461747
am65_cpsw_nuss_rx_irq,
1747-
0, dev_name(dev), common);
1748+
IRQF_TRIGGER_HIGH, dev_name(dev), common);
17481749
if (ret) {
17491750
dev_err(dev, "failure requesting rx irq %u, %d\n",
17501751
common->rx_chns.irq, ret);

0 commit comments

Comments
 (0)