Skip to content

Commit 6f89416

Browse files
jhovoldDaniel Lezcano
authored andcommitted
thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message
Drivers should not be logging errors on probe deferral. Switch to using dev_err_probe() to log failures when parsing the devicetree to avoid errors like: qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517 when a channel is not yet available. Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Andrew Halaney <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Daniel Lezcano <[email protected]>
1 parent c464856 commit 6f89416

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/thermal/qcom/qcom-spmi-adc-tm5.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,10 +1030,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
10301030
return irq;
10311031

10321032
ret = adc_tm5_get_dt_data(adc_tm, node);
1033-
if (ret) {
1034-
dev_err(dev, "get dt data failed: %d\n", ret);
1035-
return ret;
1036-
}
1033+
if (ret)
1034+
return dev_err_probe(dev, ret, "get dt data failed\n");
10371035

10381036
ret = adc_tm->data->init(adc_tm);
10391037
if (ret) {

0 commit comments

Comments
 (0)