smb/server: fix possible memory leak in smb2_read()

ZhangGuoDong · smfrench · commit 6fced056d2cc · 2025-10-15T06:03:09.000-05:00
Memory leak occurs when ksmbd_vfs_read() fails.
Fix this by adding the missing kvfree().

Co-developed-by: ChenXiaoSong &lt;chenxiaosong@kylinos.cn&gt;
Signed-off-by: ChenXiaoSong &lt;chenxiaosong@kylinos.cn&gt;
Signed-off-by: ZhangGuoDong &lt;zhangguodong@kylinos.cn&gt;
Acked-by: Namjae Jeon &lt;linkinjeon@kernel.org&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
@@ -6824,6 +6824,7 @@ int smb2_read(struct ksmbd_work *work)
 
 	nbytes = ksmbd_vfs_read(work, fp, length, &offset, aux_payload_buf);
 	if (nbytes < 0) {
+		kvfree(aux_payload_buf);
 		err = nbytes;
 		goto out;
 	}

Original file line number	Diff line number	Diff line change
`@@ -6824,6 +6824,7 @@ int smb2_read(struct ksmbd_work *work)`
`6824`	`6824`
`6825`	`6825`	`nbytes = ksmbd_vfs_read(work, fp, length, &offset, aux_payload_buf);`
`6826`	`6826`	`if (nbytes < 0) {`
	`6827`	`+ kvfree(aux_payload_buf);`
`6827`	`6828`	`err = nbytes;`
`6828`	`6829`	`goto out;`
`6829`	`6830`	`}`