Skip to content

Commit 7028159

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: xilinxfb: Make xilinxfb_release() return void
The function xilinxfb_release() returns zero unconditionally. Make it return void. There is no semantic change, the only effect is that it becomes obvious that the driver's .remove() callback always returns zero. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent a4f7fcd commit 7028159

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/video/fbdev/xilinxfb.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ static int xilinxfb_assign(struct platform_device *pdev,
376376
return rc;
377377
}
378378

379-
static int xilinxfb_release(struct device *dev)
379+
static void xilinxfb_release(struct device *dev)
380380
{
381381
struct xilinxfb_drvdata *drvdata = dev_get_drvdata(dev);
382382

@@ -402,8 +402,6 @@ static int xilinxfb_release(struct device *dev)
402402
if (!(drvdata->flags & BUS_ACCESS_FLAG))
403403
dcr_unmap(drvdata->dcr_host, drvdata->dcr_len);
404404
#endif
405-
406-
return 0;
407405
}
408406

409407
/* ---------------------------------------------------------------------
@@ -480,7 +478,9 @@ static int xilinxfb_of_probe(struct platform_device *pdev)
480478

481479
static int xilinxfb_of_remove(struct platform_device *op)
482480
{
483-
return xilinxfb_release(&op->dev);
481+
xilinxfb_release(&op->dev);
482+
483+
return 0;
484484
}
485485

486486
/* Match table for of_platform binding */

0 commit comments

Comments
 (0)