Skip to content

Commit 708cda3

Browse files
committed
rcuperf: Add comments explaining the high reader overhead
This commit adds comments explaining why the readers have otherwise insane levels of measurement overhead, namely that they are intended as a test load for update-side performance measurements, not as a straight-up read-side performance test. Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 653ed64 commit 708cda3

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

kernel/rcu/rcuperf.c

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,11 @@ MODULE_AUTHOR("Paul E. McKenney <[email protected]>");
6969
* value specified by nr_cpus for a read-only test.
7070
*
7171
* Various other use cases may of course be specified.
72+
*
73+
* Note that this test's readers are intended only as a test load for
74+
* the writers. The reader performance statistics will be overly
75+
* pessimistic due to the per-critical-section interrupt disabling,
76+
* test-end checks, and the pair of calls through pointers.
7277
*/
7378

7479
#ifdef MODULE
@@ -309,8 +314,10 @@ static void rcu_perf_wait_shutdown(void)
309314
}
310315

311316
/*
312-
* RCU perf reader kthread. Repeatedly does empty RCU read-side
313-
* critical section, minimizing update-side interference.
317+
* RCU perf reader kthread. Repeatedly does empty RCU read-side critical
318+
* section, minimizing update-side interference. However, the point of
319+
* this test is not to evaluate reader performance, but instead to serve
320+
* as a test load for update-side performance testing.
314321
*/
315322
static int
316323
rcu_perf_reader(void *arg)

0 commit comments

Comments
 (0)