Skip to content

Commit 709671f

Browse files
Saaem Rizvialexdeucher
authored andcommitted
drm/amd/display: Remove OTG DIV register write for Virtual signals.
[WHY] Hot plugging and then hot unplugging leads to k1 and k2 values to change, as signal is detected as a virtual signal on hot unplug. Writing these values to OTG_PIXEL_RATE_DIV register might cause primary display to blank (known hw bug). [HOW] No longer write k1 and k2 values to register if signal is virtual, we have safe guards in place in the case that k1 and k2 is unassigned so that an unknown value is not written to the register either. Cc: [email protected] Cc: Mario Limonciello <[email protected]> Reviewed-by: Samson Tam <[email protected]> Reviewed-by: Alvin Lee <[email protected]> Acked-by: Qingqing Zhuo <[email protected]> Signed-off-by: Saaem Rizvi <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 542a56e commit 709671f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1104,7 +1104,7 @@ unsigned int dcn32_calculate_dccg_k1_k2_values(struct pipe_ctx *pipe_ctx, unsign
11041104
*k2_div = PIXEL_RATE_DIV_BY_2;
11051105
else
11061106
*k2_div = PIXEL_RATE_DIV_BY_4;
1107-
} else if (dc_is_dp_signal(stream->signal) || dc_is_virtual_signal(stream->signal)) {
1107+
} else if (dc_is_dp_signal(stream->signal)) {
11081108
if (two_pix_per_container) {
11091109
*k1_div = PIXEL_RATE_DIV_BY_1;
11101110
*k2_div = PIXEL_RATE_DIV_BY_2;

0 commit comments

Comments
 (0)