Skip to content

Commit 70a9ac3

Browse files
hsiangkaoJaegeuk Kim
authored andcommitted
f2fs: fix up f2fs_lookup tracepoints
Fix up a misuse that the filename pointer isn't always valid in the ring buffer, and we should copy the content instead. Fixes: 0c5e36d ("f2fs: trace f2fs_lookup") Signed-off-by: Gao Xiang <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 6663b13 commit 70a9ac3

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

include/trace/events/f2fs.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -807,20 +807,20 @@ TRACE_EVENT(f2fs_lookup_start,
807807
TP_STRUCT__entry(
808808
__field(dev_t, dev)
809809
__field(ino_t, ino)
810-
__field(const char *, name)
810+
__string(name, dentry->d_name.name)
811811
__field(unsigned int, flags)
812812
),
813813

814814
TP_fast_assign(
815815
__entry->dev = dir->i_sb->s_dev;
816816
__entry->ino = dir->i_ino;
817-
__entry->name = dentry->d_name.name;
817+
__assign_str(name, dentry->d_name.name);
818818
__entry->flags = flags;
819819
),
820820

821821
TP_printk("dev = (%d,%d), pino = %lu, name:%s, flags:%u",
822822
show_dev_ino(__entry),
823-
__entry->name,
823+
__get_str(name),
824824
__entry->flags)
825825
);
826826

@@ -834,22 +834,22 @@ TRACE_EVENT(f2fs_lookup_end,
834834
TP_STRUCT__entry(
835835
__field(dev_t, dev)
836836
__field(ino_t, ino)
837-
__field(const char *, name)
837+
__string(name, dentry->d_name.name)
838838
__field(nid_t, cino)
839839
__field(int, err)
840840
),
841841

842842
TP_fast_assign(
843843
__entry->dev = dir->i_sb->s_dev;
844844
__entry->ino = dir->i_ino;
845-
__entry->name = dentry->d_name.name;
845+
__assign_str(name, dentry->d_name.name);
846846
__entry->cino = ino;
847847
__entry->err = err;
848848
),
849849

850850
TP_printk("dev = (%d,%d), pino = %lu, name:%s, ino:%u, err:%d",
851851
show_dev_ino(__entry),
852-
__entry->name,
852+
__get_str(name),
853853
__entry->cino,
854854
__entry->err)
855855
);

0 commit comments

Comments
 (0)