Skip to content

Commit 71150ac

Browse files
Sergey Shtylyovstorulf
authored andcommitted
mmc: bcm2835: fix deferred probing
The driver overrides the error codes and IRQ0 returned by platform_get_irq() to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe permanently instead of the deferred probing. Switch to propagating the error codes upstream. Since commit ce753ad ("platform: finally disallow IRQ0 in platform_get_irq() and its ilk") IRQ0 is no longer returned by those APIs, so we now can safely ignore it... Fixes: 660fc73 ("mmc: bcm2835: Add new driver for the sdhost controller.") Cc: [email protected] # v5.19+ Signed-off-by: Sergey Shtylyov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent f334ad4 commit 71150ac

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/mmc/host/bcm2835.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,8 +1403,8 @@ static int bcm2835_probe(struct platform_device *pdev)
14031403
host->max_clk = clk_get_rate(clk);
14041404

14051405
host->irq = platform_get_irq(pdev, 0);
1406-
if (host->irq <= 0) {
1407-
ret = -EINVAL;
1406+
if (host->irq < 0) {
1407+
ret = host->irq;
14081408
goto err;
14091409
}
14101410

0 commit comments

Comments
 (0)