Skip to content

Commit 7131fd7

Browse files
lkarpins-rhakpm00
authored andcommitted
selftests: cgroup: fix test_kmem_memcg_deletion kernel mem check
Currently, not all kernel memory usage is being accounted for. This commit switches to using the kernel entry within memory.stat which already includes kernel_stack, pagetables, and slab. The kernel entry also includes vmalloc and other additional kernel memory use cases which were missing. Link: https://lkml.kernel.org/r/bvrhe2tpsts2azaroq4ubp2slawmop6orndsswrewuscw3ugvk@kmemmrttsnc7 Signed-off-by: Lucas Karpinski <[email protected]> Acked-by: Shakeel Butt <[email protected]> Acked-by: Roman Gushchin <[email protected]> Cc: Johannes Weiner <[email protected]> Cc: Michal Hocko <[email protected]> Cc: Muchun Song <[email protected]> Cc: Shuah Khan <[email protected]> Cc: Tejun Heo <[email protected]> Cc: Zefan Li <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 004a9a3 commit 7131fd7

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

tools/testing/selftests/cgroup/test_kmem.c

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,11 @@ static int cg_run_in_subcgroups(const char *parent,
162162
* allocates some slab memory (mostly negative dentries) using 2 * NR_CPUS
163163
* threads. Then it checks the sanity of numbers on the parent level:
164164
* the total size of the cgroups should be roughly equal to
165-
* anon + file + slab + kernel_stack.
165+
* anon + file + kernel + sock.
166166
*/
167167
static int test_kmem_memcg_deletion(const char *root)
168168
{
169-
long current, slab, anon, file, kernel_stack, pagetables, percpu, sock, sum;
169+
long current, anon, file, kernel, sock, sum;
170170
int ret = KSFT_FAIL;
171171
char *parent;
172172

@@ -184,29 +184,22 @@ static int test_kmem_memcg_deletion(const char *root)
184184
goto cleanup;
185185

186186
current = cg_read_long(parent, "memory.current");
187-
slab = cg_read_key_long(parent, "memory.stat", "slab ");
188187
anon = cg_read_key_long(parent, "memory.stat", "anon ");
189188
file = cg_read_key_long(parent, "memory.stat", "file ");
190-
kernel_stack = cg_read_key_long(parent, "memory.stat", "kernel_stack ");
191-
pagetables = cg_read_key_long(parent, "memory.stat", "pagetables ");
192-
percpu = cg_read_key_long(parent, "memory.stat", "percpu ");
189+
kernel = cg_read_key_long(parent, "memory.stat", "kernel ");
193190
sock = cg_read_key_long(parent, "memory.stat", "sock ");
194-
if (current < 0 || slab < 0 || anon < 0 || file < 0 ||
195-
kernel_stack < 0 || pagetables < 0 || percpu < 0 || sock < 0)
191+
if (current < 0 || anon < 0 || file < 0 || kernel < 0 || sock < 0)
196192
goto cleanup;
197193

198-
sum = slab + anon + file + kernel_stack + pagetables + percpu + sock;
194+
sum = anon + file + kernel + sock;
199195
if (abs(sum - current) < MAX_VMSTAT_ERROR) {
200196
ret = KSFT_PASS;
201197
} else {
202198
printf("memory.current = %ld\n", current);
203-
printf("slab + anon + file + kernel_stack = %ld\n", sum);
204-
printf("slab = %ld\n", slab);
199+
printf("anon + file + kernel + sock = %ld\n", sum);
205200
printf("anon = %ld\n", anon);
206201
printf("file = %ld\n", file);
207-
printf("kernel_stack = %ld\n", kernel_stack);
208-
printf("pagetables = %ld\n", pagetables);
209-
printf("percpu = %ld\n", percpu);
202+
printf("kernel = %ld\n", kernel);
210203
printf("sock = %ld\n", sock);
211204
}
212205

0 commit comments

Comments
 (0)