lockdown: initialize local array before use to quiet static analysis

TanyaAgarwal25 · pcmoore · commit 714d87c90a76 · 2025-01-05T12:48:43.000-05:00
The static code analysis tool "Coverity Scan" pointed the following details out for further development considerations: CID 1486102: Uninitialized scalar variable (UNINIT) uninit_use_in_call: Using uninitialized value *temp when calling strlen. Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com> [PM: edit/reformat the description, subject line] Signed-off-by: Paul Moore <paul@paul-moore.com>
diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c
@@ -96,7 +96,7 @@ static int __init lockdown_lsm_init(void)
 static ssize_t lockdown_read(struct file *filp, char __user *buf, size_t count,
 			     loff_t *ppos)
 {
-	char temp[80];
+	char temp[80] = "";
 	int i, offset = 0;
 
 	for (i = 0; i < ARRAY_SIZE(lockdown_levels); i++) {

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ static int __init lockdown_lsm_init(void)`
`96`	`96`	`static ssize_t lockdown_read(struct file filp, char __user buf, size_t count,`
`97`	`97`	`loff_t *ppos)`
`98`	`98`	`{`
`99`		`- char temp[80];`
	`99`	`+ char temp[80] = "";`
`100`	`100`	`int i, offset = 0;`
`101`	`101`
`102`	`102`	`for (i = 0; i < ARRAY_SIZE(lockdown_levels); i++) {`