Skip to content

Commit 7155c44

Browse files
vladimirolteanShawn Guo
authored andcommitted
ARM: dts: ls1021a: Restore MDIO compatible to gianfar
The difference between "fsl,etsec2-mdio" and "gianfar" has to do with the .get_tbipa function, which calculates the address of the TBIPA register automatically, if not explicitly specified. [ see drivers/net/ethernet/freescale/fsl_pq_mdio.c ]. On LS1021A, the TBIPA register is at offset 0x30 within the port register block, which is what the "gianfar" method of calculating addresses actually does. Luckily, the bad "compatible" is inconsequential for ls1021a.dtsi, because the TBIPA register is explicitly specified via the second "reg" (<0x0 0x2d10030 0x0 0x4>), so the "get_tbipa" function is dead code. Nonetheless it's good to restore it to its correct value. Background discussion: https://www.spinics.net/lists/stable/msg361156.html Fixes: c7861ad ("ARM: dts: ls1021: Fix SGMII PCS link remaining down after PHY disconnect") Reported-by: Pavel Machek <[email protected]> Signed-off-by: Vladimir Oltean <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 54d6477 commit 7155c44

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm/boot/dts/ls1021a.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@
747747
};
748748

749749
mdio0: mdio@2d24000 {
750-
compatible = "fsl,etsec2-mdio";
750+
compatible = "gianfar";
751751
device_type = "mdio";
752752
#address-cells = <1>;
753753
#size-cells = <0>;
@@ -756,7 +756,7 @@
756756
};
757757

758758
mdio1: mdio@2d64000 {
759-
compatible = "fsl,etsec2-mdio";
759+
compatible = "gianfar";
760760
device_type = "mdio";
761761
#address-cells = <1>;
762762
#size-cells = <0>;

0 commit comments

Comments
 (0)