Skip to content

Commit 716f974

Browse files
Rahi374pinchartl
authored andcommitted
dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible
The i.MX8MP ISP is compatbile with the rkisp1 driver. Add it to the list of compatible strings. While at it, expand on the description of the clocks to make it clear which clock in the i.MX8MP ISP they map to, based on the names from the datasheet. Signed-off-by: Paul Elder <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Reviewed-by: Rob Herring <[email protected]> Tested-by: Alexander Stein <[email protected]> Tested-by: Adam Ford <[email protected]> Signed-off-by: Laurent Pinchart <[email protected]>
1 parent 2db6cad commit 716f974

File tree

1 file changed

+31
-6
lines changed

1 file changed

+31
-6
lines changed

Documentation/devicetree/bindings/media/rockchip-isp1.yaml

Lines changed: 31 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ description: |
1616
properties:
1717
compatible:
1818
enum:
19+
- fsl,imx8mp-isp
1920
- rockchip,px30-cif-isp
2021
- rockchip,rk3399-cif-isp
2122

@@ -36,9 +37,9 @@ properties:
3637
minItems: 3
3738
items:
3839
# isp0 and isp1
39-
- description: ISP clock
40-
- description: ISP AXI clock
41-
- description: ISP AHB clock
40+
- description: ISP clock (for imx8mp, clk)
41+
- description: ISP AXI clock (for imx8mp, m_hclk)
42+
- description: ISP AHB clock (for imx8mp, hclk)
4243
# only for isp1
4344
- description: ISP Pixel clock
4445

@@ -52,6 +53,13 @@ properties:
5253
# only for isp1
5354
- const: pclk
5455

56+
fsl,blk-ctrl:
57+
$ref: /schemas/types.yaml#/definitions/phandle-array
58+
maxItems: 1
59+
description:
60+
A phandle to the media block control for the ISP, followed by a cell
61+
containing the index of the gasket.
62+
5563
iommus:
5664
maxItems: 1
5765

@@ -113,9 +121,6 @@ required:
113121
- interrupts
114122
- clocks
115123
- clock-names
116-
- iommus
117-
- phys
118-
- phy-names
119124
- power-domains
120125
- ports
121126

@@ -143,6 +148,26 @@ allOf:
143148
required:
144149
- interrupt-names
145150

151+
- if:
152+
properties:
153+
compatible:
154+
contains:
155+
const: fsl,imx8mp-isp
156+
then:
157+
properties:
158+
iommus: false
159+
phys: false
160+
phy-names: false
161+
required:
162+
- fsl,blk-ctrl
163+
else:
164+
properties:
165+
fsl,blk-ctrl: false
166+
required:
167+
- iommus
168+
- phys
169+
- phy-names
170+
146171
additionalProperties: false
147172

148173
examples:

0 commit comments

Comments
 (0)