Skip to content

Commit 7220e8f

Browse files
edumazetkuba-moo
authored andcommitted
net: lapbether: use netdev_lockdep_set_classes() helper
drivers/net/wan/lapbether.c uses stacked devices. Like similar drivers, it must use netdev_lockdep_set_classes() to avoid LOCKDEP splats. This is similar to commit 9bfc9d6 ("hamradio: use netdev_lockdep_set_classes() helper") Fixes: 7e4d784 ("net: hold netdev instance lock during rtnetlink operations") Reported-by: [email protected] Closes: https://lore.kernel.org/lkml/[email protected]/T/#u Signed-off-by: Eric Dumazet <[email protected]> Acked-by: Stanislav Fomichev <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 4f1eaab commit 7220e8f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/wan/lapbether.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
#include <linux/lapb.h>
4040
#include <linux/init.h>
4141

42+
#include <net/netdev_lock.h>
4243
#include <net/x25device.h>
4344

4445
static const u8 bcast_addr[6] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
@@ -366,6 +367,7 @@ static const struct net_device_ops lapbeth_netdev_ops = {
366367

367368
static void lapbeth_setup(struct net_device *dev)
368369
{
370+
netdev_lockdep_set_classes(dev);
369371
dev->netdev_ops = &lapbeth_netdev_ops;
370372
dev->needs_free_netdev = true;
371373
dev->type = ARPHRD_X25;

0 commit comments

Comments
 (0)