Skip to content

Commit 7221922

Browse files
Jiri Pirkomstsirkin
authored andcommitted
virtio_balloon: convert to use virtio_find_vqs_info()
Instead of passing separate names and callbacks arrays to virtio_find_vqs(), have one of virtual_queue_info structs and pass it to virtio_find_vqs_info(). Suggested-by: Xuan Zhuo <[email protected]> Signed-off-by: Jiri Pirko <[email protected]> Message-Id: <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1 parent fc496dc commit 7221922

File tree

1 file changed

+13
-21
lines changed

1 file changed

+13
-21
lines changed

drivers/virtio/virtio_balloon.c

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -560,43 +560,35 @@ static void update_balloon_size_func(struct work_struct *work)
560560

561561
static int init_vqs(struct virtio_balloon *vb)
562562
{
563+
struct virtqueue_info vqs_info[VIRTIO_BALLOON_VQ_MAX] = {};
563564
struct virtqueue *vqs[VIRTIO_BALLOON_VQ_MAX];
564-
vq_callback_t *callbacks[VIRTIO_BALLOON_VQ_MAX];
565-
const char *names[VIRTIO_BALLOON_VQ_MAX];
566565
int err;
567566

568567
/*
569568
* Inflateq and deflateq are used unconditionally. The names[]
570569
* will be NULL if the related feature is not enabled, which will
571570
* cause no allocation for the corresponding virtqueue in find_vqs.
572571
*/
573-
callbacks[VIRTIO_BALLOON_VQ_INFLATE] = balloon_ack;
574-
names[VIRTIO_BALLOON_VQ_INFLATE] = "inflate";
575-
callbacks[VIRTIO_BALLOON_VQ_DEFLATE] = balloon_ack;
576-
names[VIRTIO_BALLOON_VQ_DEFLATE] = "deflate";
577-
callbacks[VIRTIO_BALLOON_VQ_STATS] = NULL;
578-
names[VIRTIO_BALLOON_VQ_STATS] = NULL;
579-
callbacks[VIRTIO_BALLOON_VQ_FREE_PAGE] = NULL;
580-
names[VIRTIO_BALLOON_VQ_FREE_PAGE] = NULL;
581-
names[VIRTIO_BALLOON_VQ_REPORTING] = NULL;
572+
vqs_info[VIRTIO_BALLOON_VQ_INFLATE].callback = balloon_ack;
573+
vqs_info[VIRTIO_BALLOON_VQ_INFLATE].name = "inflate";
574+
vqs_info[VIRTIO_BALLOON_VQ_DEFLATE].callback = balloon_ack;
575+
vqs_info[VIRTIO_BALLOON_VQ_DEFLATE].name = "deflate";
582576

583577
if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) {
584-
names[VIRTIO_BALLOON_VQ_STATS] = "stats";
585-
callbacks[VIRTIO_BALLOON_VQ_STATS] = stats_request;
578+
vqs_info[VIRTIO_BALLOON_VQ_STATS].name = "stats";
579+
vqs_info[VIRTIO_BALLOON_VQ_STATS].callback = stats_request;
586580
}
587581

588-
if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) {
589-
names[VIRTIO_BALLOON_VQ_FREE_PAGE] = "free_page_vq";
590-
callbacks[VIRTIO_BALLOON_VQ_FREE_PAGE] = NULL;
591-
}
582+
if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT))
583+
vqs_info[VIRTIO_BALLOON_VQ_FREE_PAGE].name = "free_page_vq";
592584

593585
if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING)) {
594-
names[VIRTIO_BALLOON_VQ_REPORTING] = "reporting_vq";
595-
callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
586+
vqs_info[VIRTIO_BALLOON_VQ_REPORTING].name = "reporting_vq";
587+
vqs_info[VIRTIO_BALLOON_VQ_REPORTING].callback = balloon_ack;
596588
}
597589

598-
err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
599-
callbacks, names, NULL);
590+
err = virtio_find_vqs_info(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
591+
vqs_info, NULL);
600592
if (err)
601593
return err;
602594

0 commit comments

Comments
 (0)