Skip to content

Commit 7231065

Browse files
bijudasKAGA-KOKO
authored andcommitted
irqchip/renesas-rzv2h: Fix wrong variable usage in rzv2h_tint_set_type()
The variable tssel_n is used for selecting TINT source and titsel_n for setting the interrupt type. The variable titsel_n is wrongly used for enabling the TINT interrupt in rzv2h_tint_set_type(). Fix this issue by using the correct variable tssel_n. While at it, move the tien variable assignment near to tssr. Fixes: 0d7605e ("irqchip: Add RZ/V2H(P) Interrupt Control Unit (ICU) driver") Reported-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Biju Das <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/all/[email protected] Closes: https://lore.kernel.org/CAMuHMdU3xJpz-jh=j7t4JreBat2of2ksP_OR3+nKAoZBr4pSxg@mail.gmail.com
1 parent 9d24521 commit 7231065

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-renesas-rzv2h.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,10 @@ static int rzv2h_tint_set_type(struct irq_data *d, unsigned int type)
301301

302302
tssr_k = ICU_TSSR_K(tint_nr);
303303
tssel_n = ICU_TSSR_TSSEL_N(tint_nr);
304+
tien = ICU_TSSR_TIEN(tssel_n);
304305

305306
titsr_k = ICU_TITSR_K(tint_nr);
306307
titsel_n = ICU_TITSR_TITSEL_N(tint_nr);
307-
tien = ICU_TSSR_TIEN(titsel_n);
308308

309309
guard(raw_spinlock)(&priv->lock);
310310

0 commit comments

Comments
 (0)