Skip to content

Commit 72b4fb4

Browse files
committed
Merge tag 'regulator-fix-v6.3-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
Pull regulator fixes from Mark Brown: "A few driver specific fixes, one build coverage issue and a couple of 'someone typed in the wrong number' style errors in describing devices to the subsystem" * tag 'regulator-fix-v6.3-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator: regulator: sm5703: Fix missing n_voltages for fixed regulators regulator: fan53555: Fix wrong TCS_SLEW_MASK regulator: fan53555: Explicitly include bits header
2 parents 789b4a4 + 7c75040 commit 72b4fb4

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

drivers/regulator/fan53555.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,19 @@
88
// Copyright (c) 2012 Marvell Technology Ltd.
99
// Yunfan Zhang <[email protected]>
1010

11+
#include <linux/bits.h>
12+
#include <linux/err.h>
13+
#include <linux/i2c.h>
1114
#include <linux/module.h>
15+
#include <linux/of_device.h>
1216
#include <linux/param.h>
13-
#include <linux/err.h>
1417
#include <linux/platform_device.h>
18+
#include <linux/regmap.h>
1519
#include <linux/regulator/driver.h>
20+
#include <linux/regulator/fan53555.h>
1621
#include <linux/regulator/machine.h>
1722
#include <linux/regulator/of_regulator.h>
18-
#include <linux/of_device.h>
19-
#include <linux/i2c.h>
2023
#include <linux/slab.h>
21-
#include <linux/regmap.h>
22-
#include <linux/regulator/fan53555.h>
2324

2425
/* Voltage setting */
2526
#define FAN53555_VSEL0 0x00
@@ -60,7 +61,7 @@
6061
#define TCS_VSEL1_MODE (1 << 6)
6162

6263
#define TCS_SLEW_SHIFT 3
63-
#define TCS_SLEW_MASK (0x3 < 3)
64+
#define TCS_SLEW_MASK GENMASK(4, 3)
6465

6566
enum fan53555_vendor {
6667
FAN53526_VENDOR_FAIRCHILD = 0,

drivers/regulator/sm5703-regulator.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ static const int sm5703_buck_voltagemap[] = {
4242
.type = REGULATOR_VOLTAGE, \
4343
.id = SM5703_USBLDO ## _id, \
4444
.ops = &sm5703_regulator_ops_fixed, \
45+
.n_voltages = 1, \
4546
.fixed_uV = SM5703_USBLDO_MICROVOLT, \
4647
.enable_reg = SM5703_REG_USBLDO12, \
4748
.enable_mask = SM5703_REG_EN_USBLDO ##_id, \
@@ -56,6 +57,7 @@ static const int sm5703_buck_voltagemap[] = {
5657
.type = REGULATOR_VOLTAGE, \
5758
.id = SM5703_VBUS, \
5859
.ops = &sm5703_regulator_ops_fixed, \
60+
.n_voltages = 1, \
5961
.fixed_uV = SM5703_VBUS_MICROVOLT, \
6062
.enable_reg = SM5703_REG_CNTL, \
6163
.enable_mask = SM5703_OPERATION_MODE_MASK, \

0 commit comments

Comments
 (0)