Skip to content

Commit 72bea13

Browse files
superna9999vinodkoul
authored andcommitted
dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: document PHY AUX clock on SM8[456]50 SoCs
The PCIe Gen4x2 PHY found in the SM8[456]50 SoCs have a second clock named "PHY_AUX_CLK" which is an input of the Global Clock Controller (GCC) which is muxed & gated then returned to the PHY as an input. Document the clock IDs to select the PIPE clock or the AUX clock, also enforce a second clock-output-names and a #clock-cells value of 1 for the PCIe Gen4x2 PHY found in the SM8[456]50 SoCs. Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/20240322-topic-sm8x50-upstream-pcie-1-phy-aux-clk-v2-1-3ec0a966d52f@linaro.org Signed-off-by: Vinod Koul <[email protected]>
1 parent 7dcb866 commit 72bea13

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ properties:
8888
- description: offset of PCIe 4-lane configuration register
8989
- description: offset of configuration bit for this PHY
9090

91-
"#clock-cells":
92-
const: 0
91+
"#clock-cells": true
9392

9493
clock-output-names:
95-
maxItems: 1
94+
minItems: 1
95+
maxItems: 2
9696

9797
"#phy-cells":
9898
const: 0
@@ -213,6 +213,27 @@ allOf:
213213
reset-names:
214214
maxItems: 1
215215

216+
- if:
217+
properties:
218+
compatible:
219+
contains:
220+
enum:
221+
- qcom,sm8450-qmp-gen4x2-pcie-phy
222+
- qcom,sm8550-qmp-gen4x2-pcie-phy
223+
- qcom,sm8650-qmp-gen4x2-pcie-phy
224+
then:
225+
properties:
226+
clock-output-names:
227+
minItems: 2
228+
"#clock-cells":
229+
const: 1
230+
else:
231+
properties:
232+
clock-output-names:
233+
maxItems: 1
234+
"#clock-cells":
235+
const: 0
236+
216237
examples:
217238
- |
218239
#include <dt-bindings/clock/qcom,gcc-sc8280xp.h>

include/dt-bindings/phy/phy-qcom-qmp.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,8 @@
1717
#define QMP_USB43DP_USB3_PHY 0
1818
#define QMP_USB43DP_DP_PHY 1
1919

20+
/* QMP PCIE PHYs */
21+
#define QMP_PCIE_PIPE_CLK 0
22+
#define QMP_PCIE_PHY_AUX_CLK 1
23+
2024
#endif /* _DT_BINDINGS_PHY_QMP */

0 commit comments

Comments
 (0)