Skip to content

Commit 72d1eda

Browse files
committed
drm/bridge: Change parameter name of drm_atomic_bridge_chain_post_disable()
drm_atomic_bridge_chain_post_disable() disables all bridges affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent be8425c commit 72d1eda

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/gpu/drm/drm_bridge.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -583,10 +583,10 @@ void drm_atomic_bridge_chain_disable(struct drm_bridge *bridge,
583583
EXPORT_SYMBOL(drm_atomic_bridge_chain_disable);
584584

585585
static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge,
586-
struct drm_atomic_state *old_state)
586+
struct drm_atomic_state *state)
587587
{
588-
if (old_state && bridge->funcs->atomic_post_disable)
589-
bridge->funcs->atomic_post_disable(bridge, old_state);
588+
if (state && bridge->funcs->atomic_post_disable)
589+
bridge->funcs->atomic_post_disable(bridge, state);
590590
else if (bridge->funcs->post_disable)
591591
bridge->funcs->post_disable(bridge);
592592
}
@@ -595,7 +595,7 @@ static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge,
595595
* drm_atomic_bridge_chain_post_disable - cleans up after disabling all bridges
596596
* in the encoder chain
597597
* @bridge: bridge control structure
598-
* @old_state: old atomic state
598+
* @state: atomic state being committed
599599
*
600600
* Calls &drm_bridge_funcs.atomic_post_disable (falls back on
601601
* &drm_bridge_funcs.post_disable) op for all the bridges in the encoder chain,
@@ -616,7 +616,7 @@ static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge,
616616
* Note: the bridge passed should be the one closest to the encoder
617617
*/
618618
void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
619-
struct drm_atomic_state *old_state)
619+
struct drm_atomic_state *state)
620620
{
621621
struct drm_encoder *encoder;
622622
struct drm_bridge *next, *limit;
@@ -663,12 +663,12 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
663663
break;
664664

665665
drm_atomic_bridge_call_post_disable(next,
666-
old_state);
666+
state);
667667
}
668668
}
669669
}
670670

671-
drm_atomic_bridge_call_post_disable(bridge, old_state);
671+
drm_atomic_bridge_call_post_disable(bridge, state);
672672

673673
if (limit)
674674
/* Jump all bridges that we have already post_disabled */

0 commit comments

Comments
 (0)