Skip to content

Commit 72f1aa6

Browse files
Wan Jiabingandersson
authored andcommitted
soc: qcom: apr: Add of_node_put() before return
Fix following coccicheck warning: ./drivers/soc/qcom/apr.c:485:1-23: WARNING: Function for_each_child_of_node should have of_node_put() before return Early exits from for_each_child_of_node should decrement the node reference counter. Fixes: 8347356 ("soc: qcom: apr: Add avs/audio tracking functionality") Signed-off-by: Wan Jiabing <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 62563bd commit 72f1aa6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/soc/qcom/apr.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,12 +492,14 @@ static int of_apr_add_pd_lookups(struct device *dev)
492492
1, &service_path);
493493
if (ret < 0) {
494494
dev_err(dev, "pdr service path missing: %d\n", ret);
495+
of_node_put(node);
495496
return ret;
496497
}
497498

498499
pds = pdr_add_lookup(apr->pdr, service_name, service_path);
499500
if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
500501
dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
502+
of_node_put(node);
501503
return PTR_ERR(pds);
502504
}
503505
}

0 commit comments

Comments
 (0)