Skip to content

Commit 732065d

Browse files
committed
Merge tag 'icc-6.2-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc into char-misc-linus
Georgi writes: interconnect fixes for v6.2-rc This contains fixes for a rare boot hang issue that has been reported on the db820c dragonboard. - dt-bindings: interconnect: Add UFS clocks to MSM8996 A2NoC - interconnect: qcom: msm8996: Provide UFS clocks to A2NoC - interconnect: qcom: msm8996: Fix regmap max_register values - interconnect: qcom: rpm: Use _optional func for provider clocks Signed-off-by: Georgi Djakov <[email protected]> * tag 'icc-6.2-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc: interconnect: qcom: rpm: Use _optional func for provider clocks interconnect: qcom: msm8996: Fix regmap max_register values interconnect: qcom: msm8996: Provide UFS clocks to A2NoC dt-bindings: interconnect: Add UFS clocks to MSM8996 A2NoC
2 parents 36225a7 + dd42ec8 commit 732065d

File tree

3 files changed

+38
-7
lines changed

3 files changed

+38
-7
lines changed

Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ allOf:
8484
- qcom,msm8939-pcnoc
8585
- qcom,msm8939-snoc
8686
- qcom,msm8996-a1noc
87-
- qcom,msm8996-a2noc
8887
- qcom,msm8996-bimc
8988
- qcom,msm8996-cnoc
9089
- qcom,msm8996-pnoc
@@ -186,6 +185,29 @@ allOf:
186185
required:
187186
- power-domains
188187

188+
- if:
189+
properties:
190+
compatible:
191+
contains:
192+
enum:
193+
- qcom,msm8996-a2noc
194+
195+
then:
196+
properties:
197+
clock-names:
198+
items:
199+
- const: bus
200+
- const: bus_a
201+
- const: aggre2_ufs_axi
202+
- const: ufs_axi
203+
204+
clocks:
205+
items:
206+
- description: Bus Clock
207+
- description: Bus A Clock
208+
- description: Aggregate2 NoC UFS AXI Clock
209+
- description: UFS AXI Clock
210+
189211
- if:
190212
properties:
191213
compatible:

drivers/interconnect/qcom/icc-rpm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ int qnoc_probe(struct platform_device *pdev)
488488
}
489489

490490
regmap_done:
491-
ret = devm_clk_bulk_get(dev, qp->num_clks, qp->bus_clks);
491+
ret = devm_clk_bulk_get_optional(dev, qp->num_clks, qp->bus_clks);
492492
if (ret)
493493
return ret;
494494

drivers/interconnect/qcom/msm8996.c

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,13 @@ static const char * const bus_a0noc_clocks[] = {
3333
"aggre0_noc_mpu_cfg"
3434
};
3535

36+
static const char * const bus_a2noc_clocks[] = {
37+
"bus",
38+
"bus_a",
39+
"aggre2_ufs_axi",
40+
"ufs_axi"
41+
};
42+
3643
static const u16 mas_a0noc_common_links[] = {
3744
MSM8996_SLAVE_A0NOC_SNOC
3845
};
@@ -1806,7 +1813,7 @@ static const struct regmap_config msm8996_a0noc_regmap_config = {
18061813
.reg_bits = 32,
18071814
.reg_stride = 4,
18081815
.val_bits = 32,
1809-
.max_register = 0x9000,
1816+
.max_register = 0x6000,
18101817
.fast_io = true
18111818
};
18121819

@@ -1830,7 +1837,7 @@ static const struct regmap_config msm8996_a1noc_regmap_config = {
18301837
.reg_bits = 32,
18311838
.reg_stride = 4,
18321839
.val_bits = 32,
1833-
.max_register = 0x7000,
1840+
.max_register = 0x5000,
18341841
.fast_io = true
18351842
};
18361843

@@ -1851,14 +1858,16 @@ static const struct regmap_config msm8996_a2noc_regmap_config = {
18511858
.reg_bits = 32,
18521859
.reg_stride = 4,
18531860
.val_bits = 32,
1854-
.max_register = 0xa000,
1861+
.max_register = 0x7000,
18551862
.fast_io = true
18561863
};
18571864

18581865
static const struct qcom_icc_desc msm8996_a2noc = {
18591866
.type = QCOM_ICC_NOC,
18601867
.nodes = a2noc_nodes,
18611868
.num_nodes = ARRAY_SIZE(a2noc_nodes),
1869+
.clocks = bus_a2noc_clocks,
1870+
.num_clocks = ARRAY_SIZE(bus_a2noc_clocks),
18621871
.regmap_cfg = &msm8996_a2noc_regmap_config
18631872
};
18641873

@@ -1877,7 +1886,7 @@ static const struct regmap_config msm8996_bimc_regmap_config = {
18771886
.reg_bits = 32,
18781887
.reg_stride = 4,
18791888
.val_bits = 32,
1880-
.max_register = 0x62000,
1889+
.max_register = 0x5a000,
18811890
.fast_io = true
18821891
};
18831892

@@ -1988,7 +1997,7 @@ static const struct regmap_config msm8996_mnoc_regmap_config = {
19881997
.reg_bits = 32,
19891998
.reg_stride = 4,
19901999
.val_bits = 32,
1991-
.max_register = 0x20000,
2000+
.max_register = 0x1c000,
19922001
.fast_io = true
19932002
};
19942003

0 commit comments

Comments
 (0)