Skip to content

Commit 7337f92

Browse files
chleroymcgrof
authored andcommitted
module: Rename debug_align() as strict_align()
debug_align() was added by commit 84e1c6b ("x86: Add RO/NX protection for loadable kernel modules") At that time the config item was CONFIG_DEBUG_SET_MODULE_RONX. But nowadays it has changed to CONFIG_STRICT_MODULE_RWX and debug_align() is confusing because it has nothing to do with DEBUG. Rename it strict_align() Signed-off-by: Christophe Leroy <[email protected]> Signed-off-by: Luis Chamberlain <[email protected]>
1 parent ef50505 commit 7337f92

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

kernel/module/internal.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
* only when CONFIG_STRICT_MODULE_RWX=y
2727
*/
2828
#ifdef CONFIG_STRICT_MODULE_RWX
29-
# define debug_align(X) PAGE_ALIGN(X)
29+
# define strict_align(X) PAGE_ALIGN(X)
3030
#else
31-
# define debug_align(X) (X)
31+
# define strict_align(X) (X)
3232
#endif
3333

3434
extern struct mutex module_mutex;

kernel/module/kallsyms.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ void layout_symtab(struct module *mod, struct load_info *info)
139139
mod->core_layout.size += strtab_size;
140140
info->core_typeoffs = mod->core_layout.size;
141141
mod->core_layout.size += ndst * sizeof(char);
142-
mod->core_layout.size = debug_align(mod->core_layout.size);
142+
mod->core_layout.size = strict_align(mod->core_layout.size);
143143

144144
/* Put string table section at end of init part of module. */
145145
strsect->sh_flags |= SHF_ALLOC;
@@ -154,7 +154,7 @@ void layout_symtab(struct module *mod, struct load_info *info)
154154
mod->init_layout.size += sizeof(struct mod_kallsyms);
155155
info->init_typeoffs = mod->init_layout.size;
156156
mod->init_layout.size += nsrc * sizeof(char);
157-
mod->init_layout.size = debug_align(mod->init_layout.size);
157+
mod->init_layout.size = strict_align(mod->init_layout.size);
158158
}
159159

160160
/*

kernel/module/main.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1447,19 +1447,19 @@ static void layout_sections(struct module *mod, struct load_info *info)
14471447
}
14481448
switch (m) {
14491449
case 0: /* executable */
1450-
mod->core_layout.size = debug_align(mod->core_layout.size);
1450+
mod->core_layout.size = strict_align(mod->core_layout.size);
14511451
mod->core_layout.text_size = mod->core_layout.size;
14521452
break;
14531453
case 1: /* RO: text and ro-data */
1454-
mod->core_layout.size = debug_align(mod->core_layout.size);
1454+
mod->core_layout.size = strict_align(mod->core_layout.size);
14551455
mod->core_layout.ro_size = mod->core_layout.size;
14561456
break;
14571457
case 2: /* RO after init */
1458-
mod->core_layout.size = debug_align(mod->core_layout.size);
1458+
mod->core_layout.size = strict_align(mod->core_layout.size);
14591459
mod->core_layout.ro_after_init_size = mod->core_layout.size;
14601460
break;
14611461
case 4: /* whole core */
1462-
mod->core_layout.size = debug_align(mod->core_layout.size);
1462+
mod->core_layout.size = strict_align(mod->core_layout.size);
14631463
break;
14641464
}
14651465
}
@@ -1481,11 +1481,11 @@ static void layout_sections(struct module *mod, struct load_info *info)
14811481
}
14821482
switch (m) {
14831483
case 0: /* executable */
1484-
mod->init_layout.size = debug_align(mod->init_layout.size);
1484+
mod->init_layout.size = strict_align(mod->init_layout.size);
14851485
mod->init_layout.text_size = mod->init_layout.size;
14861486
break;
14871487
case 1: /* RO: text and ro-data */
1488-
mod->init_layout.size = debug_align(mod->init_layout.size);
1488+
mod->init_layout.size = strict_align(mod->init_layout.size);
14891489
mod->init_layout.ro_size = mod->init_layout.size;
14901490
break;
14911491
case 2:
@@ -1496,7 +1496,7 @@ static void layout_sections(struct module *mod, struct load_info *info)
14961496
mod->init_layout.ro_after_init_size = mod->init_layout.ro_size;
14971497
break;
14981498
case 4: /* whole init */
1499-
mod->init_layout.size = debug_align(mod->init_layout.size);
1499+
mod->init_layout.size = strict_align(mod->init_layout.size);
15001500
break;
15011501
}
15021502
}

0 commit comments

Comments
 (0)