Skip to content

Commit 738b150

Browse files
committed
ARM: dts: omap4-droid4: Fix occasional lost wakeirq for uart1
Looks like using the UART CTS pin does not always trigger for a wake-up when the SoC is idle. This is probably because the modem first uses gpio_149 to signal the SoC that data will be sent, and the CTS will only get used later when the data transfer is starting. Let's fix the issue by configuring the gpio_149 pad as the wakeirq for UART. We have gpio_149 managed by the USB PHY for powering up the right USB mode, and after that, the gpio gets recycled as the modem wake-up pin. If needeed, the USB PHY can also later on be configured to use gpio_149 pad as the wakeirq as a shared irq. Let's also configure the missing properties for uart-has-rtscts and current-speed for the modem port while at it. We already configure the hardware flow control pins with uart1_pins pinctrl setting. Cc: [email protected] Cc: Merlijn Wajer <[email protected]> Cc: Pavel Machek <[email protected]> Cc: Sebastian Reichel <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 30fa60c commit 738b150

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

arch/arm/boot/dts/motorola-mapphone-common.dtsi

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -723,14 +723,18 @@
723723
};
724724

725725
/*
726-
* As uart1 is wired to mdm6600 with rts and cts, we can use the cts pin for
727-
* uart1 wakeirq.
726+
* The uart1 port is wired to mdm6600 with rts and cts. The modem uses gpio_149
727+
* for wake-up events for both the USB PHY and the UART. We can use gpio_149
728+
* pad as the shared wakeirq for the UART rather than the RX or CTS pad as we
729+
* have gpio_149 trigger before the UART transfer starts.
728730
*/
729731
&uart1 {
730732
pinctrl-names = "default";
731733
pinctrl-0 = <&uart1_pins>;
732734
interrupts-extended = <&wakeupgen GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH
733-
&omap4_pmx_core 0xfc>;
735+
&omap4_pmx_core 0x110>;
736+
uart-has-rtscts;
737+
current-speed = <115200>;
734738
};
735739

736740
&uart3 {

0 commit comments

Comments
 (0)